Repository navigation
fix(ci): harden JS lint steps — fix mastra-agentmesh TS errors, remove soft-fail masks - #2745
Merged
Imran Siddique (imran-siddique) merged 1 commit intoJun 2, 2026
Conversation
nuthalapativarun
requested a review
from Imran Siddique (imran-siddique)
as a code owner
June 1, 2026 17:27
github-actions
Bot
added
integration/mastra-agentmesh
scripts/ci/cd
size/S
🤖 AI Agent: contributor-guide — View details
Welcome, and thank you for your contribution! Great job identifying and fixing the TypeScript errors while improving CI reliability. Before we can merge, please ensure:
Let us know if you need any help! |
|
🟡 Contributor Check: MEDIUM
Automated check by AGT Contributor Check. |
github-actions
Bot
added
the
needs-review:MEDIUM
…e soft-fail masks
Both `Lint mastra-agentmesh` and `Lint copilot-governance` CI steps used
`2>/dev/null || true`, silently swallowing real TypeScript errors.
- mastra-agentmesh/tsconfig.json: add "DOM" to lib so TextEncoder and
crypto.subtle globals are recognised (TS2304 × 2).
- mastra-agentmesh/src/audit.ts: replace Node.js crypto try/catch with
the Web Crypto API path only; Node 18+ (CI uses Node 20) exposes
`crypto.subtle` as a global, so the dynamic `import("crypto")` that
required @types/node is no longer needed (TS2307 × 1).
- .github/workflows/ci.yml: remove `2>/dev/null || true` from both lint
steps so failures surface in CI.
`tsc --noEmit` now passes with zero errors in both packages.
Signed-off-by: Varun Nuthalapati <nuthalapativarun@gmail.com>
nuthalapativarun
force-pushed
the
fix/ci-lint-hardening-mastra-copilot
branch
from
June 2, 2026 00:10
42a863e to
2b3202d
Compare
Imran Siddique (imran-siddique)
enabled auto-merge (squash)
June 2, 2026 06:32
Imran Siddique (imran-siddique)
approved these changes
Jun 2, 2026
Imran Siddique (imran-siddique)
merged commit Jun 2, 2026
7df31f0
into
microsoft:main
103 of 106 checks passed
MohammadHaroonAbuomar
added a commit
to MohammadHaroonAbuomar/agt-acs
that referenced
this pull request
Jun 2, 2026
Bring 4 new upstream commits into the AGT 5.0 / ACS branch: - docs: polish docs site (UX enhancement, clean IA) (microsoft#2771) - fix(mesh-sdk): close client-side gap with POP-aware relay/registry (v4.0.0) (microsoft#2772) - fix(attestation): make verify_evidence strict by default (CVSS 8.1) (microsoft#2769) - fix(ci): harden JS lint steps - fix mastra-agentmesh TS errors (microsoft#2745) Signed-off-by: MohammadHaroonAbuomar <40180927+MohammadHaroonAbuomar@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both
Lint mastra-agentmeshandLint copilot-governanceCI steps used2>/dev/null || true, silently swallowing TypeScript errors and making those lint gates meaningless.mastra-agentmesh had three real TS errors:
TS2307–Cannot find module 'crypto'(dynamicimport("crypto")requires@types/node)TS2304–Cannot find name 'TextEncoder'(DOM type not in lib)TS2304–Cannot find name 'crypto'(DOM global not in lib)Fixes applied:
tsconfig.json: added"DOM"tolib— resolvesTextEncoderandcrypto.subtleglobals.src/audit.ts: replaced the Node.jscryptotry/catch fallback with the Web Crypto API path only. Node 18+ (CI uses Node 20) exposescrypto.subtleas a global, so the dynamicimport("crypto")that required@types/nodeis no longer needed.ci.yml: removed2>/dev/null || truefrom both lint steps so failures surface in CI going forward.tsc --noEmitpasses with zero errors in both packages after this change.Type of Change
maintenance
Package(s) Affected
docs/root
Checklist
Attribution & Prior Art
N/A
AI Assistance
Changes reviewed and verified manually. Able to explain every change.
IP, Patents, and Licensing
No IP concerns.
Related Issues
N/A