-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Python: .NET: Fix .NET conversation memory in DevUI (#3484) #4294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
victordibia
wants to merge
10
commits into
main
Choose a base branch
from
devui_dot_net_memory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+388
−16
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
798d868
Fix .NET conversation memory in DevUI (#3484)
victordibia 4be48e5
Merge branch 'main' into devui_dot_net_memory
victordibia cee4f23
formatting fixes
victordibia 5222710
fix memory regression in python devui , fix for #4123
victordibia 24f19ba
Fix for #3983: Added _get_event_type() helper that safely accesses ev…
victordibia 3bc06d0
format fixes
victordibia 571ddab
Merge branch 'main' into devui_dot_net_memory
victordibia 902d8e1
lint fixes
victordibia db8ffa4
Merge branch 'main' into devui_dot_net_memory
victordibia 1b9e259
Merge branch 'main' into devui_dot_net_memory
victordibia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 113 additions & 0 deletions
113
...et/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Converters/ItemResourceConversions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| // Copyright (c) Microsoft. All rights reserved. | ||
|
|
||
| using System.Collections.Generic; | ||
| using System.Text.Json; | ||
| using Microsoft.Agents.AI.Hosting.OpenAI.Responses.Models; | ||
| using Microsoft.Extensions.AI; | ||
|
|
||
| namespace Microsoft.Agents.AI.Hosting.OpenAI.Responses.Converters; | ||
|
|
||
| /// <summary> | ||
| /// Converts stored <see cref="ItemResource"/> objects back to <see cref="ChatMessage"/> objects | ||
| /// for injecting conversation history into agent execution. | ||
| /// </summary> | ||
| internal static class ItemResourceConversions | ||
| { | ||
| /// <summary> | ||
| /// Converts a sequence of <see cref="ItemResource"/> items to a list of <see cref="ChatMessage"/> objects. | ||
| /// Only converts message, function call, and function result items. Other item types are skipped. | ||
| /// </summary> | ||
| public static List<ChatMessage> ToChatMessages(IEnumerable<ItemResource> items) | ||
| { | ||
| var messages = new List<ChatMessage>(); | ||
|
|
||
| foreach (var item in items) | ||
| { | ||
| switch (item) | ||
| { | ||
| case ResponsesUserMessageItemResource userMsg: | ||
| messages.Add(new ChatMessage(ChatRole.User, ConvertContents(userMsg.Content))); | ||
| break; | ||
|
|
||
| case ResponsesAssistantMessageItemResource assistantMsg: | ||
| messages.Add(new ChatMessage(ChatRole.Assistant, ConvertContents(assistantMsg.Content))); | ||
| break; | ||
|
|
||
| case ResponsesSystemMessageItemResource systemMsg: | ||
| messages.Add(new ChatMessage(ChatRole.System, ConvertContents(systemMsg.Content))); | ||
| break; | ||
|
|
||
| case ResponsesDeveloperMessageItemResource developerMsg: | ||
| messages.Add(new ChatMessage(new ChatRole("developer"), ConvertContents(developerMsg.Content))); | ||
| break; | ||
|
|
||
| case FunctionToolCallItemResource funcCall: | ||
| var arguments = ParseArguments(funcCall.Arguments); | ||
| messages.Add(new ChatMessage(ChatRole.Assistant, | ||
| [ | ||
| new FunctionCallContent(funcCall.CallId, funcCall.Name, arguments) | ||
| ])); | ||
| break; | ||
|
|
||
| case FunctionToolCallOutputItemResource funcOutput: | ||
| messages.Add(new ChatMessage(ChatRole.Tool, | ||
| [ | ||
| new FunctionResultContent(funcOutput.CallId, funcOutput.Output) | ||
| ])); | ||
| break; | ||
|
|
||
| // Skip all other item types (reasoning, executor_action, web_search, etc.) | ||
| // They are not relevant for conversation context. | ||
| } | ||
| } | ||
|
|
||
| return messages; | ||
| } | ||
|
|
||
| private static List<AIContent> ConvertContents(List<ItemContent> contents) | ||
| { | ||
| var result = new List<AIContent>(); | ||
| foreach (var content in contents) | ||
| { | ||
| var aiContent = ItemContentConverter.ToAIContent(content); | ||
| if (aiContent is not null) | ||
| { | ||
| result.Add(aiContent); | ||
| } | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| private static Dictionary<string, object?>? ParseArguments(string? argumentsJson) | ||
| { | ||
| if (string.IsNullOrEmpty(argumentsJson)) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| try | ||
| { | ||
| using var doc = JsonDocument.Parse(argumentsJson); | ||
| var result = new Dictionary<string, object?>(); | ||
| foreach (var property in doc.RootElement.EnumerateObject()) | ||
| { | ||
| result[property.Name] = property.Value.ValueKind switch | ||
| { | ||
| JsonValueKind.String => property.Value.GetString(), | ||
| JsonValueKind.Number => property.Value.GetDouble(), | ||
| JsonValueKind.True => true, | ||
| JsonValueKind.False => false, | ||
| JsonValueKind.Null => null, | ||
| _ => property.Value.GetRawText() | ||
| }; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
| catch (JsonException) | ||
| { | ||
| return null; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.