Python: Filter response_format from MCP tool call kwargs#3494
Merged
giles17 merged 4 commits intomicrosoft:mainfrom Feb 3, 2026
Merged
Python: Filter response_format from MCP tool call kwargs#3494giles17 merged 4 commits intomicrosoft:mainfrom
giles17 merged 4 commits intomicrosoft:mainfrom
Conversation
Member
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix a bug where MCP tool calls fail when non-serializable framework arguments like response_format are passed through. The fix adds response_format to the exclusion list in the call_tool method's filtering logic.
Changes:
- Added
response_formatto the framework kwargs exclusion set inMCPTool.call_tool()method - Added three unit tests for logging level configuration in MCP connections (unrelated to the PR's stated purpose)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| python/packages/core/agent_framework/_mcp.py | Adds response_format to the exclusion set when filtering kwargs before passing to MCP session |
| python/packages/core/tests/core/test_mcp.py | Adds three tests for MCP server logging level configuration (appears unrelated to response_format filtering) |
dmytrostruk
approved these changes
Jan 29, 2026
moonbox3
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Filters out response_format from kwargs before forwarding to MCP servers, preventing serialization errors when using structured outputs with MCP tools.
Also added three unit tests for logging level configuration in MCP connections (unrelated to the PR's stated purpose).
Resolves #3483
Description
Contribution Checklist