Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trim/AOT annotations to WinUI XAML behaviors #255

Merged
merged 11 commits into from
Jul 24, 2024

Conversation

Sergio0694
Copy link
Member

This PR introduces the following changes:

  • Update the .NET TFM from .NET 5 to .NET 8
    • .NET 5 is EOL, .NET 6 is going to be EOL in a few months, .NET 8 has gone GA for over a year already now
    • We also need .NET 8 to be able to set IsAotCompatible
  • Bump WASDK dependency to latest stable
  • Add trim/AOT annotations to the XAML behaviors projects

Copy link
Collaborator

@azchohfi azchohfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs to bump the version and make sure our build/release process is going to work fine with net8. We'll likely need to update our ADO build.

Copy link
Member

@mgoertz-msft mgoertz-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@azchohfi azchohfi merged commit 14267d0 into microsoft:main Jul 24, 2024
1 check passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/aot-annotations2 branch July 24, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants