Skip to content

Require Templates PR pipeline via internal dev/Templates path gate#6588

Merged
DinahK-2SO merged 12 commits into
mainfrom
user/DinahK-2SO/templates-pr-pipeline-policy
Jul 6, 2026
Merged

Require Templates PR pipeline via internal dev/Templates path gate#6588
DinahK-2SO merged 12 commits into
mainfrom
user/DinahK-2SO/templates-pr-pipeline-policy

Conversation

@DinahK-2SO

@DinahK-2SO DinahK-2SO commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Adds WindowsAppSDK-Templates-PR pipeline to "/azp run" with path gate so it can verify GitHub PRs that touch dev/Templates/** without blocking unrelated PRs.

Details:

  • Make the WindowsAppSDK-Templates-PR pipeline to be triggered by "/azp run" comments, for github PRs targeting main branch (set in policy, not in this code)
  • when the WindowsAppSDK-Templates-PR pipeline launched, it checks with git diff to see if the current PR changes anything under folder dev/Templates.
    • If not, WindowsAppSDK-Templates-PR will be passed, and silently skip templates check.
    • if the templates folder is touched, run build verifications and smoke tests for all the templates.
  • By default WindowsAppSDK-Templates-PR runs with the latest stable version of WindowsAppSDK. Adding a variable (by default = "*") to customize the WindowsAppSDK version on pipeline's launching page, so users can run tests for their target packages (if they want to).

Always-run gate diffs the PR; skips build/test/VSIX when dev/Templates unchanged so it can be a required GitHub check without blocking other PRs. Add optional dependsOn/condition params to shared stage templates.
@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@DinahK-2SO
DinahK-2SO force-pushed the user/DinahK-2SO/templates-pr-pipeline-policy branch from 057002c to 2f35acb Compare June 30, 2026 06:15
@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run WindowsAppSDK-Templates-PR

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

git fetch writes progress to stderr on success; ErrorActionPreference Stop turned that into a terminating NativeCommandError. Use Continue and enforce fail-fast via LASTEXITCODE + throw.
@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run WindowsAppSDK-Templates-PR

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Templates float Version="*"; print dotnet list package (WindowsAppSDK/SDK.BuildTools) and active .NET SDK before each build so failures name the exact package build and catch regressions in published packages.
Trim the Write-ResolvedPackageVersions comment to four concise lines.
@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run WindowsAppSDK-Templates-PR

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Pipeline/stage/script parameter (default *) flows to dotnet new --wasdk-version so a failed run can re-run with a pinned version. Fix BlankApp csproj to use the version tokens so pinning actually applies.
@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run WindowsAppSDK-Templates-PR

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Scenario 7b builds the default * and fails on a broken latest. When a specific WindowsAppSDK version is pinned, skip that one build so the pinned run can go green; default runs still get the early warning.
cannot get version number

When version is *, query nuget.org for the latest official version number (no package download from it), scaffold with that exact version (restored from the internal feed), and log it. Fall back to * with a warning if nuget.org is unreachable.
@DinahK-2SO
DinahK-2SO force-pushed the user/DinahK-2SO/templates-pr-pipeline-policy branch from 38d5f52 to 561bc56 Compare July 2, 2026 04:51
@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run WindowsAppSDK-Templates-PR

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

CI cannot reach nuget.org. Query the internal ADO feed (auth via System.AccessToken), exclude prerelease and 2.63.* dev builds, take the highest = latest official. Map System.AccessToken into the smoke-test task.
@DinahK-2SO
DinahK-2SO force-pushed the user/DinahK-2SO/templates-pr-pipeline-policy branch from 58b75bc to 089ca30 Compare July 2, 2026 06:47
@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run WindowsAppSDK-Templates-PR

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@DinahK-2SO
DinahK-2SO requested a review from LegendaryBlair July 2, 2026 08:03
@DinahK-2SO
DinahK-2SO enabled auto-merge (squash) July 4, 2026 13:27
@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@DinahK-2SO

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@DinahK-2SO
DinahK-2SO merged commit d8388d3 into main Jul 6, 2026
50 of 56 checks passed
@DinahK-2SO
DinahK-2SO deleted the user/DinahK-2SO/templates-pr-pipeline-policy branch July 6, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants