Skip to content

Test-VisualStudioComponent now detects missing components #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DefaultRyan merged 1 commit into from
Dec 20, 2025
Merged

Test-VisualStudioComponent now detects missing components #6092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tools/DevCheck/DevCheck.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,10 @@ function Test-VisualStudioComponent
try
{
$value = Run-Process $vswhere_exe $args -throwIfExitCodeIsFailure $true
$path = $path -replace [environment]::NewLine, ''
Copy link
Contributor

@guimafelipe guimafelipe Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this line removed? What was it doing before?

Copy link
Member Author

@DefaultRyan DefaultRyan Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was doing nothing. $path wasn't used anywhere else in the function. It looks like it was a bit of copy/paste debris from earlier refactoring.

if ([string]::IsNullOrEmpty($value))
{
throw "Component"
}
Write-Verbose "Visual Studio component $($component) = $($value)"
return 0
}
Expand Down
Loading