Skip to content

Remove unnecessary explicit Close #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2024
Merged

Remove unnecessary explicit Close #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Samples/Islands/DrawingIsland/DrawingCppTestApp/WinMain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,27 @@ int __stdcall wWinMain(HINSTANCE, HINSTANCE, PWSTR, int)
auto compositor = winrt::Compositor();
auto island = winrt::DrawingIsland(compositor).Island();

// Associating the AppWindow with the DispatcherQueue on which the ContentIsland is created
// will ensure that the ContentIsland is Closed when the AppWindow closes.
auto window = winrt::AppWindow::Create();
window.AssociateWithDispatcherQueue(queue);
window.Closing(
[island, queue](auto&&, auto&&)
[queue](auto&&, auto&&)
{
island.Close();
// Ensure the DispatcherQueue exits the event loop on close.
queue.EnqueueEventLoopExit();
});

window.Title(L"Drawing C++ TestApp");
window.Show();

// Create a ContentSiteBridge and connect the ContentIsland to it.
auto siteBridge = winrt::DesktopChildSiteBridge::Create(compositor, window.Id());
siteBridge.ResizePolicy(winrt::ContentSizePolicy::ResizeContentToParentWindow);
siteBridge.Show();
siteBridge.Connect(island);

// Move initial focus to the island.
// Move initial focus to the ContentIsland.
auto focusNavigationHost = winrt::InputFocusNavigationHost::GetForSiteBridge(siteBridge);
focusNavigationHost.NavigateFocus(winrt::FocusNavigationRequest::Create(
winrt::FocusNavigationReason::Programmatic));
Expand Down