Skip to content

Conversation

j-leungyy
Copy link
Contributor

update implementation from wrl to winrtcpp COM
use WIL return macro
add debug trace
add preferred mediatype support NV12 (SimpleFrameGenerator.cpp/h)
fix mediatype missing attributel (bitrate)
add IMFActivate, IMFSampleAllocator interfaces and implementation
update hardcoded args with named variables
cleanup use of StreamIndex vs StreamId
add sample KSControl

…pleFrameGenerator), fix Mediatype missing attribute (bitrate), add IMFActivate, IMFSampleAllocator interface and implementation, update hardcode arg with named variables, cleanup sample for StreamIndex and StreamId, add sample KSControl
@NaveenThum
Copy link

@absubba is added to the review. #Closed

@NaveenThum
Copy link

Lower priority ask: There is an ask from Canon if SimpleMediaSource has been validated with MJPEG coming out. Is it possible to accommodate that?

@j-leungyy
Copy link
Contributor Author

j-leungyy commented Apr 26, 2021

Lower priority ask: There is an ask from Canon if SimpleMediaSource has been validated with MJPEG coming out. Is it possible to accommodate that?

I can look into that. are they looking for a way to generate mjpeg frames, or simply deliver the mjpeg frames that a physical camera generates?. If latter, I would also refer them to look into the virtual camera. This can be done by the HW mediasource that wraps a physical camera that produce mjpeg.


In reply to: 827010008


In reply to: 827010008


In reply to: 827010008


In reply to: 827010008

@j-leungyy j-leungyy marked this pull request as ready for review May 5, 2021 22:36
@NaveenThum
Copy link

They stream MJPEG from DSLR through SimpleMediaSource. Understood the benefit of virtual camera. However reach of virtual camera is still limited to Cobalt+ only.


In reply to: 827010008

Copy link

@NaveenThum NaveenThum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NeoAdonis NeoAdonis merged commit 4fe5787 into microsoft:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants