-
Notifications
You must be signed in to change notification settings - Fork 5k
update simplemediasource sample #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update simplemediasource sample #614
Conversation
…pleFrameGenerator), fix Mediatype missing attribute (bitrate), add IMFActivate, IMFSampleAllocator interface and implementation, update hardcode arg with named variables, cleanup sample for StreamIndex and StreamId, add sample KSControl
general/SimpleMediaSource/MediaSource/SimpleMediaSourceActivate.cpp
Outdated
Show resolved
Hide resolved
general/SimpleMediaSource/MediaSource/SimpleMediaSourceActivate.h
Outdated
Show resolved
Hide resolved
@absubba is added to the review. #Closed |
Lower priority ask: There is an ask from Canon if SimpleMediaSource has been validated with MJPEG coming out. Is it possible to accommodate that? |
I can look into that. are they looking for a way to generate mjpeg frames, or simply deliver the mjpeg frames that a physical camera generates?. If latter, I would also refer them to look into the virtual camera. This can be done by the HW mediasource that wraps a physical camera that produce mjpeg. In reply to: 827010008 In reply to: 827010008 In reply to: 827010008 In reply to: 827010008 |
They stream MJPEG from DSLR through SimpleMediaSource. Understood the benefit of virtual camera. However reach of virtual camera is still limited to Cobalt+ only. In reply to: 827010008 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update implementation from wrl to winrtcpp COM
use WIL return macro
add debug trace
add preferred mediatype support NV12 (SimpleFrameGenerator.cpp/h)
fix mediatype missing attributel (bitrate)
add IMFActivate, IMFSampleAllocator interfaces and implementation
update hardcoded args with named variables
cleanup use of StreamIndex vs StreamId
add sample KSControl