Replace MainWindow with plain Window in sample projects #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zakariathr22
reviewed
Oct 5, 2025
| private void createNewWindow_Click(object sender, RoutedEventArgs e) | ||
| { | ||
| var newWindow = new MainWindow(); | ||
| var newWindow = new Window |
There was a problem hiding this comment.
Reading this was painful 😅, can't we just create a NewWindow or SecondaryWindow?
There was a problem hiding this comment.
My intension was to avoid adding custom code to the sample as much as possible, but sure I can do that.🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
WindowHelper.CreateWindow()to return a plainWindowinstead ofMainWindow, which was tightly coupled to several static members.Motivation and Context
Fixes #2062.
How Has This Been Tested?
Manually tested.
Screenshots (if appropriate):
Types of changes