Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screen reader] Describe automatic properties and add FullDescription #1223

Merged
merged 10 commits into from
Apr 3, 2023

Conversation

citelao
Copy link
Contributor

@citelao citelao commented Mar 25, 2023

Description

Today, the Screen reader guidance does not include FullDescription documentation, and it also implies that many properties must be set manually. This change fills those gaps and clarifies some aspects of designing for screen readers.

This is intended to be the first of a few edits to the accessibility section.

Motivation and Context

There are new accessibility pages in the gallery, each with concrete examples. This change clarifies some examples and adds more:

  • Accessible name
    • Add a more robust description of accessible name
    • Add examples of automatic accessible name
    • Moved redundant controls to Raw view
  • FullDescription, HelpText, and PosInSet
    • Add overall description of these common properties
    • Add example of FullDescription and HelpText
    • Add example of automatic PosInSet/SizeOfSet
  • Visual tree
    • Add description of and motivations for visual trees.
  • General
    • Add accessible headings to the headings in all examples
    • Add accessible headings to page titles

How Has This Been Tested?

Deployed locally.

  • Narrator correctly narrates new content.
  • Links work.

Screenshots

first set of page changes

remaining changes to the page

Types of changes

  • New feature (non-breaking change which adds functionality)

@citelao
Copy link
Contributor Author

citelao commented Mar 25, 2023

Fixes #1227

@karkarl
Copy link
Collaborator

karkarl commented Apr 1, 2023

Looks good! Feel free to merge in whenever you're ready.

@karkarl karkarl merged commit f4953ee into microsoft:main Apr 3, 2023
@citelao citelao deleted the user/besto/screen_reader branch April 3, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants