Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InfoBadge #1219

Merged
merged 5 commits into from
Mar 29, 2023
Merged

Add InfoBadge #1219

merged 5 commits into from
Mar 29, 2023

Conversation

ghost1372
Copy link
Contributor

Description

Added InfoBadge Example

Motivation and Context

InfoBadge is missing in Samples and winui-gallery

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use StaticResource

WinUIGallery/ControlPages/InfoBadgePage.xaml Outdated Show resolved Hide resolved
Copy link
Contributor

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lang tags

WinUIGallery/DataModel/ControlInfoData.json Outdated Show resolved Hide resolved
WinUIGallery/DataModel/ControlInfoData.json Outdated Show resolved Hide resolved
Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost1372 Except for two missing quotes this seems to work well :)! Thanks for adding!

EDIT: added missing quotes.

WinUIGallery/ControlPages/InfoBadgePage.xaml Outdated Show resolved Hide resolved
@niels9001 niels9001 self-requested a review March 29, 2023 11:45
@niels9001 niels9001 merged commit 2acd918 into microsoft:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants