-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounded Corners Sample #375
Comments
I would like to work on this, just telling everyone |
@Chips1234 - fantastic! Please reach out if you have any questions 😁 CC: @chigy @kikisaints for FYI |
@Chips1234 , could you tell me why you are trying to do that? We should just show rounding of the corner of the light-up and not start redesigning the control with this effort. |
I’m trying to put it into a border as shown here. I tried |
@Chips1234 , I wanted to share how we do work for WinUI in terms of how each sample apps and documents are connected and we use them to help developers/designers. I thought this is important for you to be aware as you investigate the work you would work on this proposal. This proposal touches on 3 ways we communicate with our developer/designer audiences:
Let me know if you have any questions about this. |
@kikisaints , please take a look and comment on @Chips1234 comment here?
|
@stmoy So you want a separate page on corner radius or do you just want a new example in the existing pages (e.g. new example on the button page)? |
I think a separate page would be the best for this, |
Ok
…________________________________
From: Marcel Wagner <notifications@github.com>
Sent: Wednesday, July 15, 2020 11:37:25 AM
To: microsoft/Xaml-Controls-Gallery <Xaml-Controls-Gallery@noreply.github.com>
Cc: Eric Tian <tian.eric@hotmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [microsoft/Xaml-Controls-Gallery] Rounded Corners Sample (#375)
I think a separate page would be the best for this,
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#375 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALKX3RSFOFE5JGPF5DOVLKDR3XZOLANCNFSM4LF4NTVA>.
|
@chigy If I set CornerRadius, I get this: Warning, XLS1105, The property ‘CornerRadius’ on type ‘Button’ is not available in the target platform minimum version (10.0.17134.0) supported by this project. I can set a conditional namespace though, is that what you want me to do? |
+1
Conditional Xaml would be the appropriate way to handle this, yes. In addition, please be sure to set the |
Ok
…________________________________
From: Steven Moyes <notifications@github.com>
Sent: Thursday, July 16, 2020 1:09:56 PM
To: microsoft/Xaml-Controls-Gallery <Xaml-Controls-Gallery@noreply.github.com>
Cc: Eric Tian <tian.eric@hotmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [microsoft/Xaml-Controls-Gallery] Rounded Corners Sample (#375)
I think a separate page would be the best for this,
+1
I can set a conditional namespace though, is that what you want me to do?
Conditional Xaml would be the appropriate way to handle this, yes. In addition, please be sure to set the MinimumUniversalAPIContract on the ControlExample.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#375 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALKX3RSGX2K7XYPV7FYVXGLR35NBJANCNFSM4LF4NTVA>.
|
a slider would be pretty cool! btw is Fluent XAML Theme Editor (https://www.microsoft.com/store/productId/9N2XD3Q8X57C or https://github.com/microsoft/fluent-xaml-theme-editor) dead? |
CC: @kikisaints for this:
I believe the answer is "no, not dead - just not being actively invested in" |
Is this still an issue with the latest version? |
@Jay-o-Way I'm pretty sure this is still relevant given there exists no sample that I know of that showcases this. |
Is this a totally new sample, an addition to an existing sample page, or a modification of an existing sample page?
If this is an addition/modification to an existing sample page, which one?
Describe the sample
Add a new sample that shows off:
Consider adding a link to the Xaml Fluent Theme Editor which also supports these scenarios.
Is your sample request related to a problem? Please describe it
Additional context
The text was updated successfully, but these errors were encountered: