Fix drawing tests for the new TAEF world and fix OS X tests. #1948
Conversation
* Fix interoperability with TAEF setup/teardown. * Add a TAEF entrypoint and clear the win32 stuff out of the OS X one.
| <ItemGroup> | ||
|
|
||
| <ClangCompile Include="$(StarboardBasePath)\tests\unittests\CoreGraphics.Drawing\EntryPoint.cpp" /> | ||
| <ClangCompile Include="$(StarboardBasePath)\tests\unittests\CoreGraphics.Drawing\TAEFEntryPoint.cpp" /> |
There was a problem hiding this comment.
TAEFEntryPoint [](start = 85, length = 14)
Nice! much cleaner.
| GTEST_TEST_CLASS_NAME_(test_case_name, test_name)::AddToRegistry(); \ | ||
| void GTEST_TEST_CLASS_NAME_(test_case_name, test_name)::TestBody() | ||
|
|
||
| # define TEST_P(test_case_name, test_name) GTEST_TEST_P_(test_case_name, test_name, test_case_name) |
There was a problem hiding this comment.
TEST_P [](start = 9, length = 6)
Just so I understand this, you are modifying the gtest api to have another level of indirection here so we can do the interstitial doodad?
| #define IF_NOT_EXISTS_BEGIN(name) | ||
| #define IF_NOT_EXISTS_END | ||
| #endif | ||
| #endif |
| GTEST_TEST_CLASS_NAME_(test_case_name, test_name)::AddToRegistry(); \ | ||
| void GTEST_TEST_CLASS_NAME_(test_case_name, test_name)::TestBody() | ||
|
|
||
| # define TEST_P(test_case_name, test_name) GTEST_TEST_P_(test_case_name, test_name, test_case_name) |
|
|
||
| static std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> converter; | ||
| return converter.from_bytes(CFStringGetCStringPtr(string, kCFStringEncodingUTF8)); | ||
| } |
There was a problem hiding this comment.
add a newline before this guy? I was confused what the log test thing did until I realized this was separate.
| #endif | ||
|
|
||
| #ifdef TARGET_OS_MAC | ||
| #define LOG_TEST_FILE(...) |
There was a problem hiding this comment.
nah, not necessary to record the property in an xml file we don't generate for a platform we don't want to diff on :)
There was a problem hiding this comment.
fair. Would be useful to move this macro to TestFramework for the benefit of other tests?
In reply to: 100652177 [](ancestors = 100652177)
|
@bbowman Since we changed the gtest API, the interstitial is only used as the base class. Its name does not get embedded anywhere 🗡 |
|
yep. I see that now. sweet sword. In reply to: 279105585 [](ancestors = 279105585) |
|
|
6 participants
Additionally, this pull request fixes:
Fixes #1941, #1940.