Skip to content

Conditionally remove ICU from build #2643

Open

Description

ICU is now present in the Creators Update in C:\Windows\System32. WinObjC should ship two versions of the binaries that depend on ICU or shim them to allow for transparent replacement with the system version. Consumers should then only get ICU in the app if they ship with a MinTargetPlatform lower than the Creators Update.

This will also change the ICU init path as we right now feed ICU a huge static data blob (from icudat.dll) and the system version uses different data sources.

Additional testing will likely need to be adjusted / verified as the change in binary and data source may lead to ever so slightly different results as we've seen before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions