Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent spelling of "Signalling" #14

Merged
merged 1 commit into from
Oct 15, 2017
Merged

Conversation

SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks commented Oct 15, 2017

find -type f -exec sed -i -e 's/Signall/Signal/g;s/signall/signal/g' {} \;
mv ./Samples/PeerCC-Sample/Signalling ./Samples/PeerCC-Sample/Signaling
mv ./Samples/PeerCC-Sample/Signaling/Signalling.cs ./Samples/PeerCC-Sample/Signaling/Signaling.cs
mv ./Samples/DataChannelOrtc/DataChannelOrtc/Signalling ./Samples/DataChannelOrtc/DataChannelOrtc/Signaling

(using American spelling this time; to be consistent with standard spelling used, e.g.: onsignalingstatechange)

@jamescadd jamescadd merged commit 989eb77 into microsoft:master Oct 15, 2017
@jamescadd
Copy link
Member

Thanks Samuel! These all evolved at different times from different codebases and it looks like we got out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants