fix calculateColor function #1121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix sorting co2Scale to not be in place, change finding scaleIndex to be equal to closestNum (not greater than).
|
This PR has not seen any action for a while! Closing for now, but it can be reopened at a later date. |
|
looks awesome! thanks @konradrydzak ✨ I'm adding @saragibby here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sorting co2Scale to not be in place, change finding scaleIndex to be equal to closestNum (not greater than).
Previously co2Scale was sorted in place and scaleIndex was taken for a value greater than closestNum (if one existed, otherwise it would return -1).
After the changes, scaleIndex should correctly get the exact index of the closestNum value in co2Scale.
Probably also requires the same changes to Web-Dev-For-Beginners/5-browser-extension/solution/ and Web-Dev-For-Beginners/5-browser-extension/3-background-tasks-and-performance/translations/.