Skip to content

Commit

Permalink
[CRYPTO] all: Pass tfm instead of ctx to algorithms
Browse files Browse the repository at this point in the history
Up until now algorithms have been happy to get a context pointer since
they know everything that's in the tfm already (e.g., alignment, block
size).

However, once we have parameterised algorithms, such information will
be specific to each tfm.  So the algorithm API needs to be changed to
pass the tfm structure instead of the context pointer.

This patch is basically a text substitution.  The only tricky bit is
the assembly routines that need to get the context pointer offset
through asm-offsets.h.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
herbertx committed Jun 26, 2006
1 parent 4360010 commit 6c2bb98
Show file tree
Hide file tree
Showing 37 changed files with 349 additions and 331 deletions.
28 changes: 14 additions & 14 deletions arch/i386/crypto/aes-i586-asm.S
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,19 @@
.file "aes-i586-asm.S"
.text

#define tlen 1024 // length of each of 4 'xor' arrays (256 32-bit words)

// offsets to parameters with one register pushed onto stack
#include <asm/asm-offsets.h>

#define in_blk 16 // input byte array address parameter
#define out_blk 12 // output byte array address parameter
#define ctx 8 // AES context structure
#define tlen 1024 // length of each of 4 'xor' arrays (256 32-bit words)

// offsets in context structure
/* offsets to parameters with one register pushed onto stack */
#define tfm 8
#define out_blk 12
#define in_blk 16

#define ekey 0 // encryption key schedule base address
#define nrnd 256 // number of rounds
#define dkey 260 // decryption key schedule base address
/* offsets in crypto_tfm structure */
#define ekey (crypto_tfm_ctx_offset + 0)
#define nrnd (crypto_tfm_ctx_offset + 256)
#define dkey (crypto_tfm_ctx_offset + 260)

// register mapping for encrypt and decrypt subroutines

Expand Down Expand Up @@ -217,7 +217,7 @@
do_col (table, r5,r0,r1,r4, r2,r3); /* idx=r5 */

// AES (Rijndael) Encryption Subroutine
/* void aes_enc_blk(void *ctx, u8 *out_blk, const u8 *in_blk) */
/* void aes_enc_blk(struct crypto_tfm *tfm, u8 *out_blk, const u8 *in_blk) */

.global aes_enc_blk

Expand All @@ -228,7 +228,7 @@

aes_enc_blk:
push %ebp
mov ctx(%esp),%ebp // pointer to context
mov tfm(%esp),%ebp

// CAUTION: the order and the values used in these assigns
// rely on the register mappings
Expand Down Expand Up @@ -293,7 +293,7 @@ aes_enc_blk:
ret

// AES (Rijndael) Decryption Subroutine
/* void aes_dec_blk(void *ctx, u8 *out_blk, const u8 *in_blk) */
/* void aes_dec_blk(struct crypto_tfm *tfm, u8 *out_blk, const u8 *in_blk) */

.global aes_dec_blk

Expand All @@ -304,7 +304,7 @@ aes_enc_blk:

aes_dec_blk:
push %ebp
mov ctx(%esp),%ebp // pointer to context
mov tfm(%esp),%ebp

// CAUTION: the order and the values used in these assigns
// rely on the register mappings
Expand Down
10 changes: 5 additions & 5 deletions arch/i386/crypto/aes.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
#include <linux/crypto.h>
#include <linux/linkage.h>

asmlinkage void aes_enc_blk(void *ctx, u8 *dst, const u8 *src);
asmlinkage void aes_dec_blk(void *ctx, u8 *dst, const u8 *src);
asmlinkage void aes_enc_blk(struct crypto_tfm *tfm, u8 *dst, const u8 *src);
asmlinkage void aes_dec_blk(struct crypto_tfm *tfm, u8 *dst, const u8 *src);

#define AES_MIN_KEY_SIZE 16
#define AES_MAX_KEY_SIZE 32
Expand Down Expand Up @@ -378,12 +378,12 @@ static void gen_tabs(void)
k[8*(i)+11] = ss[3]; \
}

static int
aes_set_key(void *ctx_arg, const u8 *in_key, unsigned int key_len, u32 *flags)
static int aes_set_key(struct crypto_tfm *tfm, const u8 *in_key,
unsigned int key_len, u32 *flags)
{
int i;
u32 ss[8];
struct aes_ctx *ctx = ctx_arg;
struct aes_ctx *ctx = crypto_tfm_ctx(tfm);
const __le32 *key = (const __le32 *)in_key;

/* encryption schedule */
Expand Down
3 changes: 3 additions & 0 deletions arch/i386/kernel/asm-offsets.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* to extract and format the required data.
*/

#include <linux/crypto.h>
#include <linux/sched.h>
#include <linux/signal.h>
#include <linux/personality.h>
Expand Down Expand Up @@ -69,4 +70,6 @@ void foo(void)

DEFINE(PAGE_SIZE_asm, PAGE_SIZE);
DEFINE(VSYSCALL_BASE, __fix_to_virt(FIX_VSYSCALL));

OFFSET(crypto_tfm_ctx_offset, crypto_tfm, __crt_ctx);
}
14 changes: 7 additions & 7 deletions arch/s390/crypto/aes_s390.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ struct s390_aes_ctx {
int key_len;
};

static int aes_set_key(void *ctx, const u8 *in_key, unsigned int key_len,
u32 *flags)
static int aes_set_key(struct crypto_tfm *tfm, const u8 *in_key,
unsigned int key_len, u32 *flags)
{
struct s390_aes_ctx *sctx = ctx;
struct s390_aes_ctx *sctx = crypto_tfm_ctx(tfm);

switch (key_len) {
case 16:
Expand Down Expand Up @@ -70,9 +70,9 @@ static int aes_set_key(void *ctx, const u8 *in_key, unsigned int key_len,
return -EINVAL;
}

static void aes_encrypt(void *ctx, u8 *out, const u8 *in)
static void aes_encrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
{
const struct s390_aes_ctx *sctx = ctx;
const struct s390_aes_ctx *sctx = crypto_tfm_ctx(tfm);

switch (sctx->key_len) {
case 16:
Expand All @@ -90,9 +90,9 @@ static void aes_encrypt(void *ctx, u8 *out, const u8 *in)
}
}

static void aes_decrypt(void *ctx, u8 *out, const u8 *in)
static void aes_decrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
{
const struct s390_aes_ctx *sctx = ctx;
const struct s390_aes_ctx *sctx = crypto_tfm_ctx(tfm);

switch (sctx->key_len) {
case 16:
Expand Down
42 changes: 21 additions & 21 deletions arch/s390/crypto/des_s390.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ struct crypt_s390_des3_192_ctx {
u8 key[DES3_192_KEY_SIZE];
};

static int des_setkey(void *ctx, const u8 *key, unsigned int keylen,
u32 *flags)
static int des_setkey(struct crypto_tfm *tfm, const u8 *key,
unsigned int keylen, u32 *flags)
{
struct crypt_s390_des_ctx *dctx = ctx;
struct crypt_s390_des_ctx *dctx = crypto_tfm_ctx(tfm);
int ret;

/* test if key is valid (not a weak key) */
Expand All @@ -57,16 +57,16 @@ static int des_setkey(void *ctx, const u8 *key, unsigned int keylen,
return ret;
}

static void des_encrypt(void *ctx, u8 *out, const u8 *in)
static void des_encrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
{
struct crypt_s390_des_ctx *dctx = ctx;
struct crypt_s390_des_ctx *dctx = crypto_tfm_ctx(tfm);

crypt_s390_km(KM_DEA_ENCRYPT, dctx->key, out, in, DES_BLOCK_SIZE);
}

static void des_decrypt(void *ctx, u8 *out, const u8 *in)
static void des_decrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
{
struct crypt_s390_des_ctx *dctx = ctx;
struct crypt_s390_des_ctx *dctx = crypto_tfm_ctx(tfm);

crypt_s390_km(KM_DEA_DECRYPT, dctx->key, out, in, DES_BLOCK_SIZE);
}
Expand Down Expand Up @@ -166,11 +166,11 @@ static struct crypto_alg des_alg = {
* Implementers MUST reject keys that exhibit this property.
*
*/
static int des3_128_setkey(void *ctx, const u8 *key, unsigned int keylen,
u32 *flags)
static int des3_128_setkey(struct crypto_tfm *tfm, const u8 *key,
unsigned int keylen, u32 *flags)
{
int i, ret;
struct crypt_s390_des3_128_ctx *dctx = ctx;
struct crypt_s390_des3_128_ctx *dctx = crypto_tfm_ctx(tfm);
const u8* temp_key = key;

if (!(memcmp(key, &key[DES_KEY_SIZE], DES_KEY_SIZE))) {
Expand All @@ -186,17 +186,17 @@ static int des3_128_setkey(void *ctx, const u8 *key, unsigned int keylen,
return 0;
}

static void des3_128_encrypt(void *ctx, u8 *dst, const u8 *src)
static void des3_128_encrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
{
struct crypt_s390_des3_128_ctx *dctx = ctx;
struct crypt_s390_des3_128_ctx *dctx = crypto_tfm_ctx(tfm);

crypt_s390_km(KM_TDEA_128_ENCRYPT, dctx->key, dst, (void*)src,
DES3_128_BLOCK_SIZE);
}

static void des3_128_decrypt(void *ctx, u8 *dst, const u8 *src)
static void des3_128_decrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
{
struct crypt_s390_des3_128_ctx *dctx = ctx;
struct crypt_s390_des3_128_ctx *dctx = crypto_tfm_ctx(tfm);

crypt_s390_km(KM_TDEA_128_DECRYPT, dctx->key, dst, (void*)src,
DES3_128_BLOCK_SIZE);
Expand Down Expand Up @@ -302,11 +302,11 @@ static struct crypto_alg des3_128_alg = {
* property.
*
*/
static int des3_192_setkey(void *ctx, const u8 *key, unsigned int keylen,
u32 *flags)
static int des3_192_setkey(struct crypto_tfm *tfm, const u8 *key,
unsigned int keylen, u32 *flags)
{
int i, ret;
struct crypt_s390_des3_192_ctx *dctx = ctx;
struct crypt_s390_des3_192_ctx *dctx = crypto_tfm_ctx(tfm);
const u8* temp_key = key;

if (!(memcmp(key, &key[DES_KEY_SIZE], DES_KEY_SIZE) &&
Expand All @@ -325,17 +325,17 @@ static int des3_192_setkey(void *ctx, const u8 *key, unsigned int keylen,
return 0;
}

static void des3_192_encrypt(void *ctx, u8 *dst, const u8 *src)
static void des3_192_encrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
{
struct crypt_s390_des3_192_ctx *dctx = ctx;
struct crypt_s390_des3_192_ctx *dctx = crypto_tfm_ctx(tfm);

crypt_s390_km(KM_TDEA_192_ENCRYPT, dctx->key, dst, (void*)src,
DES3_192_BLOCK_SIZE);
}

static void des3_192_decrypt(void *ctx, u8 *dst, const u8 *src)
static void des3_192_decrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
{
struct crypt_s390_des3_192_ctx *dctx = ctx;
struct crypt_s390_des3_192_ctx *dctx = crypto_tfm_ctx(tfm);

crypt_s390_km(KM_TDEA_192_DECRYPT, dctx->key, dst, (void*)src,
DES3_192_BLOCK_SIZE);
Expand Down
15 changes: 7 additions & 8 deletions arch/s390/crypto/sha1_s390.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ struct crypt_s390_sha1_ctx {
u8 buffer[2 * SHA1_BLOCK_SIZE];
};

static void sha1_init(void *ctx_arg)
static void sha1_init(struct crypto_tfm *tfm)
{
struct crypt_s390_sha1_ctx *ctx = ctx_arg;
struct crypt_s390_sha1_ctx *ctx = crypto_tfm_ctx(tfm);
static const u32 initstate[5] = {
0x67452301,
0xEFCDAB89,
Expand All @@ -56,13 +56,13 @@ static void sha1_init(void *ctx_arg)
ctx->buf_len = 0;
}

static void
sha1_update(void *ctx, const u8 *data, unsigned int len)
static void sha1_update(struct crypto_tfm *tfm, const u8 *data,
unsigned int len)
{
struct crypt_s390_sha1_ctx *sctx;
long imd_len;

sctx = ctx;
sctx = crypto_tfm_ctx(tfm);
sctx->count += len * 8; //message bit length

//anything in buffer yet? -> must be completed
Expand Down Expand Up @@ -111,10 +111,9 @@ pad_message(struct crypt_s390_sha1_ctx* sctx)
}

/* Add padding and return the message digest. */
static void
sha1_final(void* ctx, u8 *out)
static void sha1_final(struct crypto_tfm *tfm, u8 *out)
{
struct crypt_s390_sha1_ctx *sctx = ctx;
struct crypt_s390_sha1_ctx *sctx = crypto_tfm_ctx(tfm);

//must perform manual padding
pad_message(sctx);
Expand Down
13 changes: 7 additions & 6 deletions arch/s390/crypto/sha256_s390.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ struct s390_sha256_ctx {
u8 buf[2 * SHA256_BLOCK_SIZE];
};

static void sha256_init(void *ctx)
static void sha256_init(struct crypto_tfm *tfm)
{
struct s390_sha256_ctx *sctx = ctx;
struct s390_sha256_ctx *sctx = crypto_tfm_ctx(tfm);

sctx->state[0] = 0x6a09e667;
sctx->state[1] = 0xbb67ae85;
Expand All @@ -46,9 +46,10 @@ static void sha256_init(void *ctx)
sctx->count = 0;
}

static void sha256_update(void *ctx, const u8 *data, unsigned int len)
static void sha256_update(struct crypto_tfm *tfm, const u8 *data,
unsigned int len)
{
struct s390_sha256_ctx *sctx = ctx;
struct s390_sha256_ctx *sctx = crypto_tfm_ctx(tfm);
unsigned int index;
int ret;

Expand Down Expand Up @@ -107,9 +108,9 @@ static void pad_message(struct s390_sha256_ctx* sctx)
}

/* Add padding and return the message digest */
static void sha256_final(void* ctx, u8 *out)
static void sha256_final(struct crypto_tfm *tfm, u8 *out)
{
struct s390_sha256_ctx *sctx = ctx;
struct s390_sha256_ctx *sctx = crypto_tfm_ctx(tfm);

/* must perform manual padding */
pad_message(sctx);
Expand Down
18 changes: 11 additions & 7 deletions arch/x86_64/crypto/aes-x86_64-asm.S
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@

.text

#include <asm/asm-offsets.h>

#define BASE crypto_tfm_ctx_offset

#define R1 %rax
#define R1E %eax
#define R1X %ax
Expand Down Expand Up @@ -46,19 +50,19 @@
#define R10 %r10
#define R11 %r11

#define prologue(FUNC,BASE,B128,B192,r1,r2,r3,r4,r5,r6,r7,r8,r9,r10,r11) \
#define prologue(FUNC,KEY,B128,B192,r1,r2,r3,r4,r5,r6,r7,r8,r9,r10,r11) \
.global FUNC; \
.type FUNC,@function; \
.align 8; \
FUNC: movq r1,r2; \
movq r3,r4; \
leaq BASE+52(r8),r9; \
leaq BASE+KEY+52(r8),r9; \
movq r10,r11; \
movl (r7),r5 ## E; \
movl 4(r7),r1 ## E; \
movl 8(r7),r6 ## E; \
movl 12(r7),r7 ## E; \
movl (r8),r10 ## E; \
movl BASE(r8),r10 ## E; \
xorl -48(r9),r5 ## E; \
xorl -44(r9),r1 ## E; \
xorl -40(r9),r6 ## E; \
Expand Down Expand Up @@ -128,8 +132,8 @@ FUNC: movq r1,r2; \
movl r3 ## E,r1 ## E; \
movl r4 ## E,r2 ## E;

#define entry(FUNC,BASE,B128,B192) \
prologue(FUNC,BASE,B128,B192,R2,R8,R7,R9,R1,R3,R4,R6,R10,R5,R11)
#define entry(FUNC,KEY,B128,B192) \
prologue(FUNC,KEY,B128,B192,R2,R8,R7,R9,R1,R3,R4,R6,R10,R5,R11)

#define return epilogue(R8,R2,R9,R7,R5,R6,R3,R4,R11)

Expand All @@ -147,7 +151,7 @@ FUNC: movq r1,r2; \
#define decrypt_final(TAB,OFFSET) \
round(TAB,OFFSET,R2,R1,R4,R3,R6,R5,R7,R10,R5,R6,R3,R4)

/* void aes_encrypt(void *ctx, u8 *out, const u8 *in) */
/* void aes_encrypt(stuct crypto_tfm *tfm, u8 *out, const u8 *in) */

entry(aes_encrypt,0,enc128,enc192)
encrypt_round(aes_ft_tab,-96)
Expand All @@ -166,7 +170,7 @@ enc128: encrypt_round(aes_ft_tab,-32)
encrypt_final(aes_fl_tab,112)
return

/* void aes_decrypt(void *ctx, u8 *out, const u8 *in) */
/* void aes_decrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in) */

entry(aes_decrypt,240,dec128,dec192)
decrypt_round(aes_it_tab,-96)
Expand Down
Loading

0 comments on commit 6c2bb98

Please sign in to comment.