Skip to content

Commit

Permalink
x86/cpu: Remove the pointless CPU printout
Browse files Browse the repository at this point in the history
The value of this printout is dubious at best and there is no point in
having it in two different places along with convoluted ways to reach it.

Remove it completely.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
KAGA-KOKO committed Jun 21, 2018
1 parent 05736e4 commit 55e6d27
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 25 deletions.
20 changes: 5 additions & 15 deletions arch/x86/kernel/cpu/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -663,13 +663,12 @@ void detect_ht(struct cpuinfo_x86 *c)
#ifdef CONFIG_SMP
u32 eax, ebx, ecx, edx;
int index_msb, core_bits;
static bool printed;

if (!cpu_has(c, X86_FEATURE_HT))
return;

if (cpu_has(c, X86_FEATURE_CMP_LEGACY))
goto out;
return;

if (cpu_has(c, X86_FEATURE_XTOPOLOGY))
return;
Expand All @@ -678,14 +677,14 @@ void detect_ht(struct cpuinfo_x86 *c)

smp_num_siblings = (ebx & 0xff0000) >> 16;

if (!smp_num_siblings)
smp_num_siblings = 1;

if (smp_num_siblings == 1) {
pr_info_once("CPU0: Hyper-Threading is disabled\n");
goto out;
return;
}

if (smp_num_siblings <= 1)
goto out;

index_msb = get_count_order(smp_num_siblings);
c->phys_proc_id = apic->phys_pkg_id(c->initial_apicid, index_msb);

Expand All @@ -697,15 +696,6 @@ void detect_ht(struct cpuinfo_x86 *c)

c->cpu_core_id = apic->phys_pkg_id(c->initial_apicid, index_msb) &
((1 << core_bits) - 1);

out:
if (!printed && (c->x86_max_cores * smp_num_siblings) > 1) {
pr_info("CPU: Physical Processor ID: %d\n",
c->phys_proc_id);
pr_info("CPU: Processor Core ID: %d\n",
c->cpu_core_id);
printed = 1;
}
#endif
}

Expand Down
10 changes: 0 additions & 10 deletions arch/x86/kernel/cpu/topology.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ int detect_extended_topology(struct cpuinfo_x86 *c)
unsigned int eax, ebx, ecx, edx, sub_index;
unsigned int ht_mask_width, core_plus_mask_width;
unsigned int core_select_mask, core_level_siblings;
static bool printed;

if (c->cpuid_level < 0xb)
return -1;
Expand Down Expand Up @@ -86,15 +85,6 @@ int detect_extended_topology(struct cpuinfo_x86 *c)
c->apicid = apic->phys_pkg_id(c->initial_apicid, 0);

c->x86_max_cores = (core_level_siblings / smp_num_siblings);

if (!printed) {
pr_info("CPU: Physical Processor ID: %d\n",
c->phys_proc_id);
if (c->x86_max_cores > 1)
pr_info("CPU: Processor Core ID: %d\n",
c->cpu_core_id);
printed = 1;
}
#endif
return 0;
}

0 comments on commit 55e6d27

Please sign in to comment.