Skip to content

Commit

Permalink
HID: picolcd: correct ordering of framebuffer freeing
Browse files Browse the repository at this point in the history
Fix the free() ordering (which was never reached due to wrong check).

Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Bruno Prémont authored and Jiri Kosina committed Aug 6, 2010
1 parent a106025 commit 1778ca2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hid/hid-picolcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -550,8 +550,8 @@ static void picolcd_fb_destroy(struct fb_info *info)
may_release = !*ref_cnt;
mutex_unlock(&info->lock);
if (may_release) {
framebuffer_release(info);
vfree((u8 *)info->fix.smem_start);
framebuffer_release(info);
}
}

Expand Down

0 comments on commit 1778ca2

Please sign in to comment.