Skip to content

test: disable WSLG during testing (partial revert of #14387) #14538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benhillis merged 2 commits into from
Mar 27, 2026
Merged

test: disable WSLG during testing (partial revert of #14387) #14538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c2581
Revert "test: enable virtiofs tests and enable WSLG during testing (#…
Mar 25, 2026
e10737e
enable wslg for SystemdNoClearTmpUnit test
Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/windows/Common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,6 +1450,8 @@ std::wstring LxssGenerateTestConfig(TestConfigDefaults Default)
return value;
};

// TODO: Reset guiApplications to true by default once the virtio hang is solved.
Comment thread
benhillis marked this conversation as resolved.

std::wstring newConfig =
L"[wsl2]\n"
L"crashDumpFolder=" +
Expand All @@ -1462,7 +1464,7 @@ std::wstring LxssGenerateTestConfig(TestConfigDefaults Default)
EscapePath(kernelLogs) +
L"\n"
L"telemetry=false\n" +
boolOptionToString(L"safeMode", Default.safeMode, false) + boolOptionToString(L"guiApplications", Default.guiApplications, true) +
boolOptionToString(L"safeMode", Default.safeMode, false) + boolOptionToString(L"guiApplications", Default.guiApplications, false) +
Comment thread
benhillis marked this conversation as resolved.
L"earlyBootLogging=false\n" + networkingModeToString(Default.networkingMode) + drvFsModeToString(Default.drvFsMode);

if (Default.kernel.has_value())
Expand Down
3 changes: 3 additions & 0 deletions test/windows/UnitTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,9 @@ class UnitTests
{
WSL2_TEST_ONLY();

// The X11 socket is only created when gui applications are enabled.
WslConfigChange config(LxssGenerateTestConfig({.guiApplications = true}));

// ensures that we don't leave state on exit
auto cleanup = EnableSystemd("initTimeout=0");

Expand Down