Skip to content

Merge the WSL Container SDK DLL project into the main feature branch #14172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1wizkid wants to merge 101 commits into
base: feature/wsl-for-apps
Choose a base branch
from
Open

Merge the WSL Container SDK DLL project into the main feature branch #14172

1wizkid wants to merge 101 commits into from
+1,031 −0

Conversation

@1wizkid
Copy link

@1wizkid 1wizkid commented Feb 6, 2026

this adds a new project src/windows/wslcsdk and the necessary .h and cpp files to build the WSLCSDK.DLL.

@1wizkid 1wizkid requested a review from a team as a code owner February 6, 2026 20:42
Copilot AI reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@benhillis benhillis changed the base branch from master to feature/wsl-for-apps February 6, 2026 21:51
@benhillis benhillis requested a review from a team as a code owner February 6, 2026 21:51
@benhillis
Copy link
Member

benhillis commented Feb 6, 2026

I've updated the target branch.

@benhillis benhillis requested review from Copilot and removed request for a team, Brian-Perkins and craigloewen-msft February 6, 2026 22:58
Copilot AI reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 24 comments.

OneBlue
OneBlue requested changes Feb 7, 2026
View reviewed changes
Copy link
Collaborator

@OneBlue OneBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. Added a couple comments, most of the copilot comments seem to be accurate

1wizkid and others added 8 commits February 9, 2026 08:44
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
9e817fd 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
04b5fa0 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
62b3272 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
9efaa38 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
625b73b 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
94a4450 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
3faa5ea 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
2610162 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI mentioned this pull request Feb 9, 2026
Closed
Copy link
Contributor

Copilot AI commented Feb 9, 2026

@1wizkid I've opened a new pull request, #14183, to work on those changes. Once the pull request is ready, I'll request review from you.

@benhillis benhillis requested a review from Copilot February 11, 2026 23:20
Copilot AI reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

1wizkid and others added 11 commits February 11, 2026 15:37
@1wizkid
Fix enum prefix in WslcContainerNetworkingMode
02ec8b7 
Update enum prefix to match naming convention.
@1wizkid
Update src/windows/WslcSDK/WslcsdkPrivate.h
8da8691 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
2b1ab12 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update wslcsdk.cpp
578823a
@1wizkid
Fix enum prefix in WslcContainerNetworkingMode
122c9b4 
Updated enum prefix to match naming convention.
@1wizkid
Refactor enum and type definitions for consistency
c49495e
@1wizkid
Change UINT32 to uint32_t in wslcsdk.cpp
b9ae483
@1wizkid
Change UINT32 to uint32_t in WslcsdkPrivate.h
21aa057
@1wizkid
Fix formatting and comments in wslcsdk.h
631952e
@1wizkid
Fix formatting and indentation in wslcsdk.h
b5bbbbd
@1wizkid
Merge branch 'feature/wsl-for-apps' into user/richfr
4cf4682
@benhillis benhillis requested a review from Copilot February 12, 2026 04:07
Copilot AI reviewed Feb 12, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

1wizkid and others added 10 commits February 11, 2026 20:23
@1wizkid
Update src/windows/WslcSDK/wslcsdk.cpp
5fb2287 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.cpp
ef5d9a3 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.cpp
8b54bf5 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.cpp
186c26f 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.cpp
a512f5a 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.cpp
baca242 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.cpp
83e3d54 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Update src/windows/WslcSDK/wslcsdk.h
fcc1687 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1wizkid
Merge branch 'feature/wsl-for-apps' into user/richfr
de75b49
@1wizkid
Refactor WslcContainerSettingsSetPortMapping function
11b6423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OneBlue OneBlue OneBlue requested changes

Copilot code review Copilot Copilot left review comments

@benhillis benhillis Awaiting requested review from benhillis benhillis was automatically assigned from microsoft/wsl-maintainers

+1 more reviewer

@JohnMcPMS JohnMcPMS JohnMcPMS left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@1wizkid @benhillis @JohnMcPMS @OneBlue @richfr