Skip to content

Conversation

@OneBlue
Copy link
Collaborator

@OneBlue OneBlue commented Jan 16, 2026

Summary of the Pull Request

Libraries don't need to depend on each other. This will make the build marginally faster

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings January 16, 2026 17:00
@OneBlue OneBlue requested a review from a team as a code owner January 16, 2026 17:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request optimizes the build system by removing an unnecessary build dependency between the configfile and common libraries. The change improves build parallelization and reduces build time without affecting functionality.

Changes:

  • Removed common from the add_dependencies list for the configfile target in Windows builds

@OneBlue OneBlue merged commit 76d040c into master Jan 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants