Update Microsoft.WSL.DeviceHost to remove lxutil.dll dependency #13633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion 1.0.0-20251022.1
benhillis
requested review from
OneBlue,
Copilot,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the lxutil.dll dependency from the WSL project by upgrading Microsoft.WSL.DeviceHost from version 1.0.0-20251015.1 to 1.0.0-20251022.1. The newer version of DeviceHost no longer requires lxutil.dll, allowing for cleaner dependency management.
Key changes:
- Updated Microsoft.WSL.DeviceHost package version
- Removed lxutil.dll references from build configuration, packaging, and pipeline files
- Reordered test initialization code to ensure proper configuration setup
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages.config | Updates DeviceHost package version and removes LxUtil package dependencies for both amd64 and arm64 architectures |
| CMakeLists.txt | Removes lxutil.dll from build configuration including package finding, file linking, and compile definitions |
| msipackage/package.wix.in | Removes lxutil.dll from MSI package installation files |
| .pipelines/build-stage.yml | Removes lxutil.dll from build artifact pattern matching |
| test/windows/DrvFsTests.cpp | Reorders test initialization to create WslConfigChange after LxsstuInitialize but before LxsstuLaunchWsl |
Comments suppressed due to low confidence (1)
test/windows/DrvFsTests.cpp:1
- The reordering of initialization code (moving WslConfigChange creation before LxsstuLaunchWsl) changes test behavior but lacks explanation or test coverage verifying this ordering is correct. Consider adding a test case that validates the configuration is properly applied before WSL launch, or document why this ordering change is necessary for the lxutil.dll removal.
/*++
benhillis
commented
Oct 23, 2025
| VERIFY_ARE_EQUAL(LxsstuInitialize(FALSE), TRUE); \ | ||
| VERIFY_ARE_EQUAL(LxsstuLaunchWsl(LXSST_TESTS_INSTALL_COMMAND_LINE), 0); \ | ||
| m_config.reset(new WslConfigChange(LxssGenerateTestConfig({.drvFsMode = DrvFsMode::##_mode##}))); \ | ||
| VERIFY_ARE_EQUAL(LxsstuLaunchWsl(LXSST_TESTS_INSTALL_COMMAND_LINE), 0); \ |
Member
Author
There was a problem hiding this comment.
not really related, but something I noticed. probably better to make sure the test is using the specified drvfs mode while running the install tests command.
benhillis
commented
Oct 23, 2025
Member
Author
benhillis
left a comment
benhillis
left a comment
There was a problem hiding this comment.
This is not ready to be merged yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the Microsoft.WSL.DeviceHost to version 1.0.0-20251022.1 which no longer has a dependency on lxutil.dll.