This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
chore: update & document release process #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mydiemho
commented
May 18, 2020
•
mydiemho
commented
mydiemho
force-pushed
the
myho/updateReleasePipeline
branch
2 times, most recently
from
4958d39 to
f007c86
Compare
mydiemho
force-pushed
the
myho/updateReleasePipeline
branch
from
125f7d2 to
a2689e2
Compare
wbreza
approved these changes
May 21, 2020
| @@ -0,0 +1,33 @@ | |||
| name: "GitHub & Web Release [$(SourceBranchName)] - $(Date:yyyyMMdd)$(Rev:.r)" | |||
There was a problem hiding this comment.
Was the old process not working? Looks like a full rewrite on the pipelines?
There was a problem hiding this comment.
a lot of the old process was manual. A few of AzDO task has been updated to support the functionality we need so I removed the manual pieces.
| destination: azureBlob | ||
| storage: $(DEV_STORAGE_ACCOUNT) | ||
| containerName: '$web' | ||
| # condition: eq(variables['Build.SourceBranch'], 'refs/heads/develop') |
There was a problem hiding this comment.
Should this line be commented out?
There was a problem hiding this comment.
good catch, need to remove. thought process is that preview would only go to Dev, but release from both master would update both Dev & Prod web instance
mydiemho
force-pushed
the
myho/updateReleasePipeline
branch
from
aba8432 to
dba6dfe
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
pjlittle
approved these changes
Jun 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.