Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

feat: add ability to import v1 video project #726

Merged
merged 6 commits into from
Apr 12, 2019

Conversation

elizabethhalper
Copy link
Collaborator

Adds ability to import V1 video projects

Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there :)

src/services/importService.ts Outdated Show resolved Hide resolved
src/services/importService.ts Outdated Show resolved Hide resolved
src/services/importService.ts Outdated Show resolved Hide resolved
src/services/importService.ts Outdated Show resolved Hide resolved
src/services/importService.ts Outdated Show resolved Hide resolved
src/services/importService.ts Outdated Show resolved Hide resolved
src/services/importService.ts Outdated Show resolved Hide resolved
@tbarlow12 tbarlow12 force-pushed the elhalper/17649/v1-video branch from a268d12 to cc505b7 Compare April 11, 2019 16:43
@wbreza wbreza force-pushed the elhalper/17649/v1-video branch from b2c3a91 to bb8cf48 Compare April 12, 2019 19:27
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #726 into dev-preview4 will increase coverage by 0.13%.
The diff coverage is 96.55%.

Impacted file tree graph

@@               Coverage Diff                @@
##           dev-preview4     #726      +/-   ##
================================================
+ Coverage          86.9%   87.04%   +0.13%     
================================================
  Files               125      125              
  Lines              4345     4414      +69     
  Branches            827      833       +6     
================================================
+ Hits               3776     3842      +66     
- Misses              567      570       +3     
  Partials              2        2
Impacted Files Coverage Δ
src/react/components/pages/homepage/homePage.tsx 84.48% <ø> (ø) ⬆️
src/common/localization/es-cl.ts 100% <ø> (ø) ⬆️
src/common/localization/en-us.ts 100% <ø> (ø) ⬆️
src/services/assetService.ts 98.91% <100%> (-0.04%) ⬇️
src/common/mockFactory.ts 86.75% <100%> (+0.26%) ⬆️
src/common/utils.ts 98.03% <100%> (+0.42%) ⬆️
src/services/importService.ts 96.03% <95.77%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575a233...bb8cf48. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #726 into dev-preview4 will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           dev-preview4     #726      +/-   ##
================================================
+ Coverage          86.9%   87.04%   +0.14%     
================================================
  Files               125      125              
  Lines              4345     4393      +48     
  Branches            827      834       +7     
================================================
+ Hits               3776     3824      +48     
  Misses              567      567              
  Partials              2        2
Impacted Files Coverage Δ
src/common/localization/es-cl.ts 100% <ø> (ø) ⬆️
src/common/localization/en-us.ts 100% <ø> (ø) ⬆️
src/react/components/pages/homepage/homePage.tsx 84.21% <100%> (-0.28%) ⬇️
src/services/assetService.ts 98.88% <100%> (-0.06%) ⬇️
src/services/importService.ts 98.79% <100%> (+1.06%) ⬆️
src/common/mockFactory.ts 86.75% <100%> (+0.26%) ⬆️
src/common/utils.ts 98.03% <100%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575a233...bb8cf48. Read the comment docs.

@tbarlow12 tbarlow12 self-requested a review April 12, 2019 20:35
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JacopoMangiavacchi JacopoMangiavacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wbreza wbreza merged commit e6e7456 into dev-preview4 Apr 12, 2019
@mydiemho mydiemho deleted the elhalper/17649/v1-video branch April 12, 2019 20:56
wbreza pushed a commit that referenced this pull request Apr 12, 2019
Adds ability to import V1 video projects
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants