Import region metadata from TFRecords #566

JacopoMangiavacchi · 2019-02-12T02:04:35Z

No description provided.

codecov · 2019-02-12T02:08:20Z

Codecov Report

Merging #566 into v2 will decrease coverage by 0.24%.
The diff coverage is 89.13%.

@@            Coverage Diff             @@
##               v2     #566      +/-   ##
==========================================
- Coverage   86.69%   86.44%   -0.25%     
==========================================
  Files         119      119              
  Lines        3291     3394     +103     
  Branches      560      582      +22     
==========================================
+ Hits         2853     2934      +81     
- Misses        438      460      +22

Impacted Files	Coverage Δ
...eact/components/common/assetPreview/imageAsset.tsx	`100% <ø> (ø)`	⬆️
...eact/components/common/assetPreview/videoAsset.tsx	`89.74% <ø> (-10.26%)`	⬇️
src/models/applicationState.ts	`100% <ø> (ø)`	⬆️
src/providers/export/tensorFlowRecords.ts	`76.84% <0%> (ø)`	⬆️
...iders/export/tensorFlowRecords/tensorFlowReader.ts	`92.3% <100%> (+2.3%)`	⬆️
src/common/mockFactory.ts	`86.95% <100%> (+0.05%)`	⬆️
...t/components/common/assetPreview/tfrecordAsset.tsx	`95.83% <100%> (ø)`	⬆️
src/services/assetService.ts	`96.87% <96.29%> (+1.16%)`	⬆️
src/common/strings.ts	`100% <0%> (ø)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f1afe...0ea43d0. Read the comment docs.

wbreza

Looks good - however I did have a couple of questions and suggestions.
Also - looks like you have some test failures right now.

src/providers/export/tensorFlowRecords.ts

src/react/components/common/assetPreview/tfrecordAsset.test.tsx

src/react/components/pages/editorPage/editorPage.tsx

src/services/assetService.ts

* Added unit tests for custom video player button * Added unit tests for image asset component * Added unit tests for video asset component

* Added unit tests for asset preview component * Moved components into correct location * Re-enabled canvas unit tests * Added more canvas unit tests * Refactored canvas and editor page tests

* Added unit tests for custom video player button * Added unit tests for image asset component * Added unit tests for video asset component

* Added unit tests for asset preview component * Moved components into correct location * Re-enabled canvas unit tests * Added more canvas unit tests * Refactored canvas and editor page tests

PIC123

Looks good!

src/providers/export/tensorFlowRecords/tensorFlowReader.ts

src/react/components/common/assetPreview/tfrecordAsset.test.tsx

JacopoMangiavacchi changed the title ~~Import region metadata from TFRecords~~ WIP: Import region metadata from TFRecords Feb 12, 2019

JacopoMangiavacchi force-pushed the jamangia/tfrecords-regions-tags-import branch from 3d91afd to fc6b210 Compare February 12, 2019 16:55

JacopoMangiavacchi changed the title ~~WIP: Import region metadata from TFRecords~~ Import region metadata from TFRecords Feb 12, 2019

JacopoMangiavacchi force-pushed the jamangia/tfrecords-regions-tags-import branch from ee44e4a to b0dae84 Compare February 12, 2019 23:07

wbreza approved these changes Feb 13, 2019

View reviewed changes

JacopoMangiavacchi force-pushed the jamangia/tfrecords-regions-tags-import branch from 64575fe to 6b886e4 Compare February 13, 2019 02:39

JacopoMangiavacchi requested review from tbarlow12 and PIC123 and removed request for tbarlow12 February 13, 2019 02:56

wbreza approved these changes Feb 13, 2019

View reviewed changes

wbreza and others added 19 commits February 13, 2019 10:24

WIP: Started refactoring canvas based assets

6da5d99

Wired up editor page for basic experience

758e5f0

WIP: Updated canvas to support single child element

7c5fe2c

Making progress

ae60e84

Got per frame tagging to work

fe0112e

Load and set child assets

0646987

Updated to filter out child assets from displaying in side bar

e4f32c8

Fixed issue with image regions now redrawing

8e38b91

Integrated next/previous tagged frame buttons

4425c1e

Wabrez/video test coverage (#549)

9f39294

* Added unit tests for custom video player button * Added unit tests for image asset component * Added unit tests for video asset component

Canvas / Editor Page Test Coverage (#552)

2d663de

* Added unit tests for asset preview component * Moved components into correct location * Re-enabled canvas unit tests * Added more canvas unit tests * Refactored canvas and editor page tests

Fixed issue instantiating canvas tools editor

cd6086e

Wired up editor page for basic experience

98e260d

WIP: Updated canvas to support single child element

29eaa00

Making progress

752ebb0

Wabrez/video test coverage (#549)

1ef80af

* Added unit tests for custom video player button * Added unit tests for image asset component * Added unit tests for video asset component

Load and set child assets

618e9d5

Update TFRecords functions

f2916b5

WIP: Adding TFRecord Asset Preview

c6ae7f2

wbreza and others added 22 commits February 13, 2019 10:41

Load and set child assets

27f5510

Updated to filter out child assets from displaying in side bar

3dac0bc

Fixed issue with image regions now redrawing

d835351

Integrated next/previous tagged frame buttons

c5b53df

Wabrez/video test coverage (#549)

0508935

* Added unit tests for custom video player button * Added unit tests for image asset component * Added unit tests for video asset component

Canvas / Editor Page Test Coverage (#552)

e4bea0d

* Added unit tests for asset preview component * Moved components into correct location * Re-enabled canvas unit tests * Added more canvas unit tests * Refactored canvas and editor page tests

Fixed issue instantiating canvas tools editor

a17156e

Making progress

e719373

WIP: Adding TFRecord Asset Preview

287a40a

Wired up editor page for basic experience

6b41557

WIP: Updated canvas to support single child element

75f1235

WIP: Reading Region metadata from TFRecord

160b1bf

Creating IRegion array

533f54a

Fix TFRecord Object Array Interface

60a9fb6

Replaced setTimeout() with setImmediate() in TFRecord asset test

6b0360a

Removed HEAD file created in rebase

c3a38e1

Fixed code duplication in test

16c3c0a

Resolved some PR feedback

1887dd5

Fixed import regions test

a1f1910

temporary comment some code

e859c1f

Removed comments from previous commit

ca74465

Moved ITFRecordMetadata interface to applicationState

22f26b7

JacopoMangiavacchi force-pushed the jamangia/tfrecords-regions-tags-import branch from ed80556 to 22f26b7 Compare February 13, 2019 19:12

JacopoMangiavacchi added 3 commits February 13, 2019 11:23

Fixed SonarCloud issue

6e8ae57

Removed duplicated test

ea0fe3c

Removed empty prop interfaces

66b79a9

PIC123 approved these changes Feb 13, 2019

View reviewed changes

src/providers/export/tensorFlowRecords/tensorFlowReader.ts Outdated Show resolved Hide resolved

src/react/components/common/assetPreview/tfrecordAsset.test.tsx Outdated Show resolved Hide resolved

src/react/components/common/assetPreview/tfrecordAsset.test.tsx Show resolved Hide resolved

Addressed feedback from PR

0ea43d0

JacopoMangiavacchi merged commit c715bc3 into v2 Feb 14, 2019

JacopoMangiavacchi deleted the jamangia/tfrecords-regions-tags-import branch February 14, 2019 01:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import region metadata from TFRecords #566

Import region metadata from TFRecords #566

JacopoMangiavacchi commented Feb 12, 2019

codecov bot commented Feb 12, 2019 •

edited

Loading

wbreza left a comment •

edited

Loading

PIC123 left a comment

Import region metadata from TFRecords #566

Import region metadata from TFRecords #566

Conversation

JacopoMangiavacchi commented Feb 12, 2019

codecov bot commented Feb 12, 2019 • edited Loading

Codecov Report

wbreza left a comment • edited Loading

Choose a reason for hiding this comment

PIC123 left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 12, 2019 •

edited

Loading

wbreza left a comment •

edited

Loading