Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Separate TFRecords code on different file #514

Merged
merged 5 commits into from
Jan 29, 2019

Conversation

JacopoMangiavacchi
Copy link
Contributor

WIP: Not ready yet for approving

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #514 into v2 will decrease coverage by 0.04%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #514      +/-   ##
==========================================
- Coverage   83.81%   83.76%   -0.05%     
==========================================
  Files         107      108       +1     
  Lines        3003     3000       -3     
  Branches      489      495       +6     
==========================================
- Hits         2517     2513       -4     
- Misses        486      487       +1
Impacted Files Coverage Δ
...ders/export/tensorFlowRecords/tensorFlowHelpers.ts 98.14% <100%> (+0.23%) ⬆️
src/providers/export/tensorFlowRecords.ts 88.65% <100%> (-3.5%) ⬇️
...ders/export/tensorFlowRecords/tensorFlowBuilder.ts 95.74% <95.74%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0982c3...1bd6317. Read the comment docs.

Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - Added some suggestions that may make the API easier to use.

Copy link
Collaborator

@elizabethhalper elizabethhalper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Once you address Wallace's comments I think it should be good to go

@JacopoMangiavacchi JacopoMangiavacchi merged commit 8198c41 into v2 Jan 29, 2019
@JacopoMangiavacchi JacopoMangiavacchi deleted the jamangia/split-tfrecords branch January 29, 2019 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants