Skip to content

Allow Virtual Client to use a certificate to authenticate to the proxy API #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 29, 2025

Conversation

kmjjc
Copy link
Contributor

@kmjjc kmjjc commented Jul 24, 2025

No description provided.

@kmjjc kmjjc force-pushed the users/cjhillbrand/ProxyCertificate branch from 5dc1edf to 9662a1b Compare July 24, 2025 20:21
@kmjjc
Copy link
Contributor Author

kmjjc commented Jul 24, 2025

@kmjjc please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement
@microsoft-github-policy-service agree company="Microsoft"

@kmjjc kmjjc force-pushed the users/cjhillbrand/ProxyCertificate branch 2 times, most recently from 960a667 to f999e5c Compare July 28, 2025 17:50
Copy link
Member

@cjhillbrand cjhillbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment in the rest client builder class that would be nice to be addressed, for general cleanup. Another comment that I think addresses a slight miss, can you please let me know if the certificate needs to be passed into a method?

@kmjjc kmjjc force-pushed the users/cjhillbrand/ProxyCertificate branch from f999e5c to d702255 Compare July 28, 2025 20:04
@kmjjc kmjjc requested a review from cjhillbrand July 28, 2025 20:20
Copy link
Member

@cjhillbrand cjhillbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@kmjjc kmjjc force-pushed the users/cjhillbrand/ProxyCertificate branch from d8cf668 to 4ffb602 Compare July 29, 2025 02:15
@kmjjc kmjjc enabled auto-merge (squash) July 29, 2025 02:17
@kmjjc kmjjc disabled auto-merge July 29, 2025 02:53
@kmjjc kmjjc enabled auto-merge (squash) July 29, 2025 02:54
@kmjjc kmjjc force-pushed the users/cjhillbrand/ProxyCertificate branch from 4ffb602 to 2c725da Compare July 29, 2025 20:22
@kmjjc kmjjc disabled auto-merge July 29, 2025 20:22
@kmjjc kmjjc enabled auto-merge (squash) July 29, 2025 20:33
@kmjjc kmjjc merged commit fd7cc90 into main Jul 29, 2025
5 checks passed
@kmjjc kmjjc deleted the users/cjhillbrand/ProxyCertificate branch July 29, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants