-
Notifications
You must be signed in to change notification settings - Fork 56
Allow Virtual Client to use a certificate to authenticate to the proxy API #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…certificate parsing functions instead
5dc1edf
to
9662a1b
Compare
|
960a667
to
f999e5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment in the rest client builder class that would be nice to be addressed, for general cleanup. Another comment that I think addresses a slight miss, can you please let me know if the certificate needs to be passed into a method?
src/VirtualClient/VirtualClient.Common/Rest/RestClientBuilder.cs
Outdated
Show resolved
Hide resolved
f999e5c
to
d702255
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
d8cf668
to
4ffb602
Compare
…certificate parsing functions instead
4ffb602
to
2c725da
Compare
…om/microsoft/VirtualClient into users/cjhillbrand/ProxyCertificate
No description provided.