Recording redis version in the executor #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
reviewed
Jun 5, 2025
src/VirtualClient/VirtualClient.Actions/Redis/RedisServerExecutor.cs
Outdated
Show resolved
Hide resolved
vaishalitvv
force-pushed
the
recording-redis-version-clean
branch
from
237d11e to
2b93adf
Compare
yangpanMS
reviewed
Jun 17, 2025
src/VirtualClient/VirtualClient.Actions/Redis/RedisServerExecutor.cs
Outdated
Show resolved
Hide resolved
yangpanMS
approved these changes
Jun 17, 2025
vaishalitvv
force-pushed
the
recording-redis-version-clean
branch
from
8680873 to
859c8ff
Compare
vaishalitvv
force-pushed
the
recording-redis-version-clean
branch
from
7cf3a5c to
644f24c
Compare
yangpanMS
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This update enables the recording of the Redis version on the server side using the RedisServerExecutor.
Testing:
// PERF-REDIS profile test for recording redis version change
cluster('azurecrcworkloads.westus2.kusto.windows.net').database('WorkloadDIagnostics').Traces_PPE01
| where ExperimentId == "875a16d5-7e08-481b-8bcc-5da542d6dd35"
| where CustomDimensions contains "RedisVersion"
// ABC-BASE-REDIS-S1_RR.json pkgmgr-based profile test for recording redis version change
cluster('azurecrcworkloads.westus2.kusto.windows.net').database('WorkloadDIagnostics').Traces_PPE01
| where ExperimentId == "50b572a4-e6d1-4abd-8b74-2d5621998c3f"
| where CustomDimensions contains "RedisVersion"
// ABC-BASE-REDIS-S1_RR-AzLinux.json wget-based profile test for recording redis version change
cluster('azurecrcworkloads.westus2.kusto.windows.net').database('WorkloadDIagnostics').Traces_PPE01
| where ExperimentId == "491fd0c1-df73-4312-941c-249cd903f898"
| where CustomDimensions contains "RedisVersion"