specjbb parser parses N/A metrics gracefully #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
reviewed
Jul 16, 2024
src/VirtualClient/VirtualClient.Contracts/VirtualClientLoggingExtensions.cs
Outdated
Show resolved
Hide resolved
yangpanMS
suggested changes
Jul 16, 2024
Contributor
yangpanMS
left a comment
yangpanMS
left a comment
There was a problem hiding this comment.
Please refactor to use double.NaN for not valid result. Also when will we have nan output?
Contributor
|
Do we still need this? Can I close it? |
Contributor
|
Closing. Please reopen as needed. |
yangpanMS
suggested changes
Jan 13, 2025
Contributor
yangpanMS
left a comment
yangpanMS
left a comment
There was a problem hiding this comment.
Changing the constructor will immediately break internal repo and partner extensions. Let's make sure this is necessary before proceeding.
alexffrank
approved these changes
Jan 14, 2025
nmalkapuram
force-pushed
the
users/nmalkapuram/SpecjbbParserFix
branch
from
78fba99 to
b96bfcf
Compare
…N/A explicitly. Actual resolution is fixing specjbb process for not emitting N/A values
nmalkapuram
force-pushed
the
users/nmalkapuram/SpecjbbParserFix
branch
from
b96bfcf to
2999d5e
Compare
yangpanMS
approved these changes
Jan 20, 2025
src/VirtualClient/VirtualClient.Actions.UnitTests/SPEC/SpecJbbMetricsParserTests.cs
Outdated
Show resolved
Hide resolved
nmalkapuram
force-pushed
the
users/nmalkapuram/SpecjbbParserFix
branch
from
4bab5eb to
7b4fefc
Compare
yangpanMS
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO task: https://msazure.visualstudio.com/One/_workitems/edit/28695307