FIO Job File support #300
Merged
FIO Job File support #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saibulusu
changed the title
added 4 commits
April 24, 2024 01:39
…ch uses a jobfile.
… a job file at runtime.
Contributor
|
Could we include unit test for the fio job file parsing? |
yangpanMS
reviewed
Apr 25, 2024
yangpanMS
reviewed
Apr 26, 2024
added 3 commits
April 25, 2024 17:41
Member
Author
I have added some unit tests now. |
Member
Author
|
The FioExecutor currently appends --ioengine & --filename to the command for the command line approach. I think it would make sense to keep the same in the job file approach, so I think we should expect the template job file that is provided to exclude the ioengine & file path parameters. EDIT: I was able to confirm again that if a parameter is provided in both the command line & the job file, then the value provided in the job file will take precedence. So it should not break if the parameter is provided in both. |
added 11 commits
April 27, 2024 00:59
brdeyo
requested changes
Apr 30, 2024
src/VirtualClient/VirtualClient.Main/profiles/PERF-IO-FIO-OLTP.json
Outdated
Show resolved
Hide resolved
added 2 commits
April 30, 2024 18:21
…fill and one for operations.
brdeyo
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Job File support to the FIOExecutor class. Created a profile PERF-IO-FIO-OLTP to expose this feature. Tested on linux-x64, linux-arm64, windows-x64 VMs.