Add a Generic Script Executor in VC #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imadityaa
force-pushed
the
users/adityaa/addScriptExecutor
branch
from
2f3fb8f to
4e6f463
Compare
Contributor
|
Would you please add documents for the executors? |
yangpanMS
reviewed
Jan 31, 2024
src/VirtualClient/VirtualClient.Actions.UnitTests/Examples/ScriptExecutor/invalidExample.json
Show resolved
Hide resolved
imadityaa
force-pushed
the
users/adityaa/addScriptExecutor
branch
from
4e6f463 to
43a4fba
Compare
Contributor
|
This would be super helpful! When we see failing workloads, we often want to run some custom scripts on the side to gather logs and states. |
yangpanMS
approved these changes
Feb 2, 2024
Contributor
yangpanMS
left a comment
yangpanMS
left a comment
There was a problem hiding this comment.
Great PR, nice documents and tests, check comments
src/VirtualClient/VirtualClient.Contracts/Parser/MetricsParser.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Main/profiles/EXAMPLE-EXECUTE-SCRIPT.json
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/ScriptExecutor/PythonExecutor.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/ScriptExecutor/ScriptExecutor.cs
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/ScriptExecutor/PowershellExecutor.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/ScriptExecutor/PowershellExecutor.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions.UnitTests/ScriptExecutor/PowershellExecutorTests.cs
Show resolved
Hide resolved
imadityaa
force-pushed
the
users/adityaa/addScriptExecutor
branch
from
1c3ed32 to
4059aaf
Compare
added 10 commits
February 5, 2024 18:44
imadityaa
force-pushed
the
users/adityaa/addScriptExecutor
branch
from
df6081a to
303967c
Compare
yangpanMS
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea and objective here is that any user should be able to onboard their test suites and scripts into Virtual Client without the need of any Code Change in Virtual Client that would require a new Virtual Client build. This would result in an actual Plug-n-play experience.