eliminating threads ceiling #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brdeyo
reviewed
Jan 10, 2024
Contributor
brdeyo
left a comment
brdeyo
left a comment
There was a problem hiding this comment.
Per our discussion in Teams, let's update the CaptureMetrics method to use the technique noted for (this.MetricScenario ?? this.Scenario).
Then update the existing out-of-box profile to have both the Scenario and the MetricScenario parameters defined.
brdeyo
reviewed
Jan 10, 2024
Contributor
brdeyo
left a comment
brdeyo
left a comment
There was a problem hiding this comment.
Update the minor version in the /.pipelines YAML files to the next higher number.
https://github.com/microsoft/VirtualClient/tree/main/.pipelines
brdeyo
reviewed
Jan 10, 2024
src/VirtualClient/VirtualClient.Actions/SysbenchOLTP/SysbenchOLTPClientExecutor.cs
Outdated
Show resolved
Hide resolved
brdeyo
approved these changes
Jan 10, 2024
brdeyo
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding back thread assignment flexibility w/ docs updated on sysbench / mysql limitations of note