migrate to GB6 #224
Merged
migrate to GB6 #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
reviewed
Nov 30, 2023
yangpanMS
reviewed
Nov 30, 2023
src/VirtualClient/VirtualClient.Actions/GeekBench/GeekbenchExecutor.cs
Outdated
Show resolved
Hide resolved
yangpanMS
reviewed
Nov 30, 2023
yangpanMS
reviewed
Nov 30, 2023
Contributor
yangpanMS
left a comment
yangpanMS
left a comment
There was a problem hiding this comment.
Great job! Please help test both on new machines if you haven't
yangpanMS
approved these changes
Nov 30, 2023
Contributor
yangpanMS
left a comment
yangpanMS
left a comment
There was a problem hiding this comment.
Nice! Let's remove the GeekBenchResult class if it's not referenced anywhere
added 9 commits
November 30, 2023 14:37
…used. It has been replaced by GeekbenchMetricsParser.
…sult with GeekbenchMetricsParser
…h6(.exe) to address linux-x64 issues
yangpanMS
reviewed
Dec 5, 2023
src/VirtualClient/VirtualClient.Actions/GeekBench/GeekbenchExecutor.cs
Outdated
Show resolved
Hide resolved
yangpanMS
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.