Skip to content

Resolving graph500 compilation issue #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yangpanMS merged 3 commits into from
Nov 29, 2023
Merged

Resolving graph500 compilation issue #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
639eb66
resolving graph500 compilation issue
nmalkapuram Nov 28, 2023
9603afb
resolving comments
nmalkapuram Nov 29, 2023
a068945
default flags
nmalkapuram Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/VirtualClient/VirtualClient.Actions/Graph500/Graph500Executor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,19 @@ public string EdgeFactor
}
}

/// <summary>
/// The compilerFlags that are used for make command in compiling Graph500 using mpicc compiler.
/// Mpich installs a specific version of mpicc compiler by default.
/// </summary>
public string CompilerFlags
{
get
{
this.Parameters.TryGetValue(nameof(Graph500Executor.CompilerFlags), out IConvertible compilerFlags);
return compilerFlags?.ToString();
}
}

/// <summary>
/// The path to the Graph500 executable file.
/// </summary>
Expand Down Expand Up @@ -95,7 +108,7 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel
{
using (BackgroundOperations profiling = BackgroundOperations.BeginProfiling(this, cancellationToken))
{
await this.ExecuteCommandAsync("make", null, this.PackageDirectory, cancellationToken);
await this.ExecuteCommandAsync("make", this.CompilerFlags, this.PackageDirectory, cancellationToken);

using (IProcessProxy process = await this.ExecuteCommandAsync(this.ExecutableFilePath, this.Scale + " " + this.EdgeFactor, this.PackageDirectory, telemetryContext, cancellationToken))
{
Expand Down
21 changes: 11 additions & 10 deletions src/VirtualClient/VirtualClient.Main/profiles/PERF-GRAPH500.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,20 @@
"SupportedPlatforms": "linux-x64,linux-arm64",
"SupportedOperatingSystems": "CBL-Mariner,CentOS,Debian,RedHat,Suse,Ubuntu"
},
"Parameters": {
"Scale": "10",
"EdgeFactor": "16"
},
"Parameters": {
"Scale": "10",
"EdgeFactor": "16"
},
"Actions": [
{
"Type": "Graph500Executor",
"Parameters": {
"Scenario": "GraphAlgorithms",
"PackageName": "graph500",
"Scale": "$.Parameters.Scale",
"EdgeFactor": "$.Parameters.EdgeFactor"
}
"Parameters": {
"Scenario": "GraphAlgorithms",
"PackageName": "graph500",
"Scale": "$.Parameters.Scale",
"EdgeFactor": "$.Parameters.EdgeFactor",
"CompilerFlags": "LDFLAGS=\"-lpthread -fcommon\""
}
}
],
"Dependencies": [
Expand Down