Add logging to the SafeKill method for SockPerf and Latte server-side executors to help determine if there is an error preventing the process from being effectively killed. #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brdeyo
commented
Oct 31, 2023
brdeyo
commented
- add logging to SockPerf server-side executor SafeKill method call.
- add logging to Latte server-side executor SafeKill method call.
… executors to help determine if there is an error preventing the process from being effectively killed.
yangpanMS
approved these changes
Oct 31, 2023
muskankhedia
pushed a commit
to muskankhedia/VirtualClient
that referenced
this pull request
Nov 24, 2023
… executors to help determine if there is an error preventing the process from being effectively killed. (microsoft#198)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.