Updating all thrrows of platform and arch to logging #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
reviewed
Sep 14, 2023
yangpanMS
approved these changes
Sep 14, 2023
Contributor
yangpanMS
left a comment
yangpanMS
left a comment
There was a problem hiding this comment.
It's a large set that I will trust you on this. You don't need to do this for our internal repo. I will have another PR to change these checks to an attribute. Thanks!
yangpanMS
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Virtual Client, we used to throw error if workload is not supported for current platform and architecture but if we have multiple workloads in single profile and workloads are meant to run for different permutations and combinations of platform and architecture support, it makes sense that we go on with profile and not throw error if one of the intermediate workload is not supported.