Feature to add a VCComponent parameter ContentPathTemplate to support custom file upload blob Path #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imadityaa
commented
Jul 12, 2023
imadityaa
commented
Jul 12, 2023
yangpanMS
reviewed
Jul 12, 2023
src/VirtualClient/VirtualClient.Contracts/VirtualClientComponent.cs
Outdated
Show resolved
Hide resolved
yangpanMS
reviewed
Jul 12, 2023
Contributor
yangpanMS
left a comment
yangpanMS
left a comment
There was a problem hiding this comment.
It is great feature to have! Thank you for making the change. Please modify the document we have on file uploading and the structure.
imadityaa
changed the title
imadityaa
force-pushed
the
users/adityaa/blobPath
branch
from
e3d02ba to
ff9cd32
Compare
yangpanMS
reviewed
Jul 14, 2023
src/VirtualClient/VirtualClient.Common/Extensions/CollectionExtensions.cs
Outdated
Show resolved
Hide resolved
imadityaa
force-pushed
the
users/adityaa/blobPath
branch
from
9feb07c to
0880fdc
Compare
yangpanMS
approved these changes
Jul 18, 2023
Contributor
yangpanMS
left a comment
yangpanMS
left a comment
There was a problem hiding this comment.
As discussed, we could get this in now, but please help refactor to the better design that we discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.