Add EvaluationTimeoutSample projects and readme file #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason you're not using |
|
@madskristensen there is no reason, I assume it must have been default behavior from VS since they are .NET Framework projects. |
|
It would be nice to have these sample follow as many modern and best practices as possible. That includes using PackageReference. I recommend you change it, but it's not a strict rule and we can publish without it. Let me know what you want to do |
|
The WPF project cannot be SDK styled unless we upgrade the version of VS used to build the projects to be at least VS 2019. Related: dotnet/installer#213 |
|
@madskristensen I think it is ready for check-in :) |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding tutorials for Custom Managed Debugger Visualizers here and customers wanted to be able to download the projects for which we show code snippets. Hence, we are putting them here so that they have easy access to them.