Extensibility commands on Latched controllers hard crashes VS2026 on second launch (and likely VS2022) due to early disposal

[mitchcapper]

Here is a modified version of the composite example to illustrate the issue. https://github.com/mitchcapper/VSExtensibility/tree/hybrid_project_fails. Most of it is just adding full VSSDK entrpoints/commands here you can see the issue (the working unlatched controller is commented out): https://github.com/mitchcapper/VSExtensibility/blob/hybrid_project_fails/New_Extensibility_Model/Samples/CompositeExtension/CompositeExtension/CompositeExtension.vsct#L21-L25

Adding a new extensibility command button to a MenuControllerLatched menu will cause an exception (disposed) when clicking on it.
This adds itself to the default "Debug" toolbar so make sure you have that shown.
Click the extensibility (red) command and it will crash. This wouldn't be a huge deal (I could just use a VSSDK style command) but due to the inability to get the VisualStudioExtensibility #533 this was going to be my work around, but I don't want to ditch latched.

When it is set to MenuController no problem but MenuControllerLatched it will throw a disposed exception:

System.ObjectDisposedException: 'Cannot access a disposed object.
Object name: 'PolicyBasedDataSource'.'


>	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.Internal.VisualStudio.PlatformUI.DataSource.ThrowIfDisposed() Line 267	C#
 	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.Internal.VisualStudio.PlatformUI.DataSource.QueryValue(string prop, string[] pTypeName, uint[] pDataFormat, object[] pValue) Line 392	C#
 	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.Internal.VisualStudio.PlatformUI.Utilities.QueryValue(Microsoft.VisualStudio.Shell.Interop.IVsUIDataSource ds, string prop) Line 134	C#
 	Microsoft.VisualStudio.Shell.UI.Internal.dll!Microsoft.VisualStudio.PlatformUI.VsMenuController.IsAnchorCommandFixed()	Unknown
 	Microsoft.VisualStudio.Shell.UI.Internal.dll!Microsoft.VisualStudio.PlatformUI.VsMenuController.OnCommandExecuted(object sender, System.Windows.RoutedEventArgs args)	Unknown
 	PresentationCore.dll!System.Windows.EventRoute.InvokeHandlersImpl(object source, System.Windows.RoutedEventArgs args, bool reRaised)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject sender, System.Windows.RoutedEventArgs args)	Unknown
 	PresentationFramework.dll!System.Windows.Controls.MenuItem.ClickItem(bool userInitiated)	Unknown
 	PresentationFramework.dll!System.Windows.Controls.MenuItem.HandleMouseUp(System.Windows.Input.MouseButtonEventArgs e)	Unknown
 	PresentationFramework.dll!System.Windows.Controls.MenuItem.OnMouseLeftButtonUp(System.Windows.Input.MouseButtonEventArgs e)	Unknown
 	PresentationCore.dll!System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate handler, object target)	Unknown
 	PresentationCore.dll!System.Windows.RoutedEventHandlerInfo.InvokeHandler(object target, System.Windows.RoutedEventArgs routedEventArgs)	Unknown
 	PresentationCore.dll!System.Windows.EventRoute.InvokeHandlersImpl(object source, System.Windows.RoutedEventArgs args, bool reRaised)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.ReRaiseEventAs(System.Windows.DependencyObject sender, System.Windows.RoutedEventArgs args, System.Windows.RoutedEvent newEvent)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.OnMouseUpThunk(object sender, System.Windows.Input.MouseButtonEventArgs e)	Unknown
 	PresentationCore.dll!System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate handler, object target)	Unknown
 	PresentationCore.dll!System.Windows.RoutedEventHandlerInfo.InvokeHandler(object target, System.Windows.RoutedEventArgs routedEventArgs)	Unknown
 	PresentationCore.dll!System.Windows.EventRoute.InvokeHandlersImpl(object source, System.Windows.RoutedEventArgs args, bool reRaised)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject sender, System.Windows.RoutedEventArgs args)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.RaiseTrustedEvent(System.Windows.RoutedEventArgs args)	Unknown
 	PresentationCore.dll!System.Windows.Input.InputManager.ProcessStagingArea()	Unknown
 	PresentationCore.dll!System.Windows.Input.InputProviderSite.ReportInput(System.Windows.Input.InputReport inputReport)	Unknown
 	PresentationCore.dll!System.Windows.Interop.HwndMouseInputProvider.ReportInput(System.IntPtr hwnd, System.Windows.Input.InputMode mode, int timestamp, System.Windows.Input.RawMouseActions actions, int x, int y, int wheel)	Unknown
 	PresentationCore.dll!System.Windows.Interop.HwndMouseInputProvider.FilterMessage(System.IntPtr hwnd, MS.Internal.Interop.WindowMessage msg, System.IntPtr wParam, System.IntPtr lParam, ref bool handled)	Unknown
 	PresentationCore.dll!System.Windows.Interop.HwndSource.InputFilterMessage(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam, ref bool handled)	Unknown
 	WindowsBase.dll!MS.Win32.HwndWrapper.WndProc(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam, ref bool handled)	Unknown
 	WindowsBase.dll!MS.Win32.HwndSubclass.DispatcherCallbackOperation(object o)	Unknown
 	WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate callback, object args, int numArgs)	Unknown
 	WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.TryCatchWhen(object source, System.Delegate callback, object args, int numArgs, System.Delegate catchHandler)	Unknown
 	WindowsBase.dll!System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority priority, System.TimeSpan timeout, System.Delegate method, object args, int numArgs)	Unknown
 	WindowsBase.dll!MS.Win32.HwndSubclass.SubclassWndProc(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam)	Unknown

[murphymcquet-msft]

Hi @mitchcapper, I installed your extension but was able to run the command from the latched menu without issue. I'm wondering if a more recent VS build has resolved the problem?

[mitchcapper]

First, sorry for the initial bug report I didn't list any versions or anything no idea what I was thinking. I think I was just happy to get it to repro finally I rushed the ticket.

Of course after seeing your message I do a completely clean environment from scratch and it works, pretty sure I am crazy at that point. Good news is I was not (well maybe I still am but I can repro this either way :)).

You can try to repro the easy way: Two things different from the initial report: 1) Don't click just the red circle, click the drop down arrow and then click the "CompositeNewStyleCommand" button. If it doesn't show up wait 15-30 seconds while VS fully loads. 2) This works the first time but close VS and launch it again click the same button (from the circle dropdown) and now it will crash. Now I have had it crash previously with just clicking the button itself but that is harder to repro every time vs clicking the arrow drop down which is reliable to crash.

Now if it doesn't crash on a launch after the first launch detailed instructions below:

• Started windows sandbox.

• Downloaded VS2026 preview community installer.

• Installed with Desktop C# development tools and visual studio extension development (here is the workload config if desired: .vsconfig.zip )

• Go to a powershell command prompt:

mkdir c:\test\vsext
cd c:\test\vsext
wget https://github.com/mitchcapper/VSExtensibility/archive/refs/heads/hybrid_project_fails.zip -OutFile wish_you_were_really_wget.zip
Expand-Archive -Path wish_you_were_really_wget.zip
cd C:\test\vsext\wish_you_were_really_wget\VSExtensibility-hybrid_project_fails\New_Extensibility_Model\Samples\CompositeExtension\OutOfProcComponent
dotnet build # (should succeed)
cd ..\CompositeExtension
dotnet build # (should fail)

Now it does 'fail' to build here but it still built our vsix so we are good to continue

In shell:

$vsJson = (&"c:\program files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -prerelease -format json) -join "`n"
$installs = ConvertFrom-Json -InputObject $vsJson
$installVersion=$installs[0].installationVersion
$instanceId=$installs[0].instanceId
$vsMajorVersion = $installVersion.Split('.')[0] + ".0"
$versionPrefixedId = "${vsMajorVersion}_${instanceId}"

. "c:/Program Files/Microsoft Visual Studio/18/Insiders/VSSDK/VisualStudioIntegration/Tools/Bin/CreateExpInstance.exe" /Create /RootSuffix=ExpCompTest /VsInstance=$versionPrefixedId

vsixinstaller.exe /appidinstallpath:"C:\Program Files\Microsoft Visual Studio\18\Insiders\Common7\IDE\devenv.exe" /appidname:"Visual Studio Enterprise 2026" /skuName:Community /skuVersion:$installVersion /RootSuffix:ExpCompTest "C:\test\vsext\wish_you_were_really_wget\VSExtensibility-hybrid_project_fails\bin\samples\CompositeExtension\Debug\net472\CompositeExtension.vsix"

• Wait for VSIX installer and hit modify.

• Close installer

• in shell:
  . "C:\Program Files\Microsoft Visual Studio\18\Insiders\Common7\IDE\devenv.exe" /RootSuffix ExpCompTest

• Skip, Add accounts later

• Visual C# dev settings

• Dark theme

• Start

• Continue Without Code

• Right click toolbar and click "Debug" to add it to the toolbar

• See red circle X click drop down arrow to the right
  it should look like: at this point

• see button titled CompositeNewStyleCommand click it, it should work.

• Hit OK on message box

• Exit visual studio.

• Relaunch visual studio exact same CLI (up arrow at powershell works)

• Continue without code.

• See red circle X click drop down arrow.

• see button titled CompositeNewStyleCommand click it, nothing happens and just wait for it, it should crash:)

Now you should be able to use VS to deploy the extension and have the exact same thing happen (again on second launch) but I figured CLI was the most reproducible.

I am going to be honest, I did not try the steps above from absolute scratch a second time. Installing VS in the sandbox took hours for some reason so when I was first trying to repro I manually launched VS tried to debug etc. I did try the above in a clean VS suffix, and I never installed anything in the main VS, but as I didn't want to wait hours again for VS to install I didn't go back to start.

Version info:

Microsoft Visual Studio Community
Channel: Insiders
Version: Insiders [11206.111]
Microsoft .NET Framework
Version: 4.8.09032

Azure App Service Tools v3.0.0   18.3.23.39467
Azure App Service Tools v3.0.0

C# Tools   5.3.0-1.25555.5+02d301627ed5016a4c18acd1a35e5bbc20ff03f0
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

GitHub Copilot   18.3.95.3864
GitHub Copilot is an AI pair programmer that helps you write code faster and with less work.

NuGet Package Manager   7.1.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

Visual Basic Tools   5.3.0-1.25555.5+02d301627ed5016a4c18acd1a35e5bbc20ff03f0
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools   18.0.0-alpha1.25509.2+4c68fe8482b988ef088f0968bed73810c4178fc3
Microsoft Visual F# Tools

Visual Studio IntelliCode   2.2.3159.24544
AI-assisted development for Visual Studio.
OS Name	Microsoft Windows 11 Enterprise
Version	10.0.26100 Build 26100

Stacktrace from latest VS version

 	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.Internal.VisualStudio.PlatformUI.DataSource.ThrowIfDisposed() Line 267	C#
>	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.Internal.VisualStudio.PlatformUI.DataSource.QueryValue(string prop, string[] pTypeName, uint[] pDataFormat, object[] pValue) Line 392	C#
 	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.Internal.VisualStudio.PlatformUI.Utilities.QueryValue(Microsoft.VisualStudio.Shell.Interop.IVsUIDataSource ds, string prop) Line 134	C#
 	Microsoft.VisualStudio.Shell.UI.Internal.dll!Microsoft.VisualStudio.PlatformUI.VsMenuController.IsAnchorCommandFixed()	Unknown
 	Microsoft.VisualStudio.Shell.UI.Internal.dll!Microsoft.VisualStudio.PlatformUI.VsMenuController.OnCommandExecuted(object sender, System.Windows.RoutedEventArgs args)	Unknown
 	PresentationCore.dll!System.Windows.EventRoute.InvokeHandlersImpl(object source, System.Windows.RoutedEventArgs args, bool reRaised)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject sender, System.Windows.RoutedEventArgs args)	Unknown
 	PresentationFramework.dll!System.Windows.Controls.MenuItem.ClickItem(bool userInitiated)	Unknown
 	PresentationFramework.dll!System.Windows.Controls.MenuItem.HandleMouseUp(System.Windows.Input.MouseButtonEventArgs e)	Unknown
 	PresentationFramework.dll!System.Windows.Controls.MenuItem.OnMouseLeftButtonUp(System.Windows.Input.MouseButtonEventArgs e)	Unknown
 	PresentationCore.dll!System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate handler, object target)	Unknown
 	PresentationCore.dll!System.Windows.RoutedEventHandlerInfo.InvokeHandler(object target, System.Windows.RoutedEventArgs routedEventArgs)	Unknown
 	PresentationCore.dll!System.Windows.EventRoute.InvokeHandlersImpl(object source, System.Windows.RoutedEventArgs args, bool reRaised)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.ReRaiseEventAs(System.Windows.DependencyObject sender, System.Windows.RoutedEventArgs args, System.Windows.RoutedEvent newEvent)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.OnMouseUpThunk(object sender, System.Windows.Input.MouseButtonEventArgs e)	Unknown
 	PresentationCore.dll!System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate handler, object target)	Unknown
 	PresentationCore.dll!System.Windows.RoutedEventHandlerInfo.InvokeHandler(object target, System.Windows.RoutedEventArgs routedEventArgs)	Unknown
 	PresentationCore.dll!System.Windows.EventRoute.InvokeHandlersImpl(object source, System.Windows.RoutedEventArgs args, bool reRaised)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject sender, System.Windows.RoutedEventArgs args)	Unknown
 	PresentationCore.dll!System.Windows.UIElement.RaiseTrustedEvent(System.Windows.RoutedEventArgs args)	Unknown
 	PresentationCore.dll!System.Windows.Input.InputManager.ProcessStagingArea()	Unknown
 	PresentationCore.dll!System.Windows.Input.InputManager.ProcessInput(System.Windows.Input.InputEventArgs input)	Unknown
 	PresentationCore.dll!System.Windows.Input.InputProviderSite.ReportInput(System.Windows.Input.InputReport inputReport)	Unknown
 	PresentationCore.dll!System.Windows.Interop.HwndMouseInputProvider.ReportInput(System.IntPtr hwnd, System.Windows.Input.InputMode mode, int timestamp, System.Windows.Input.RawMouseActions actions, int x, int y, int wheel)	Unknown
 	PresentationCore.dll!System.Windows.Interop.HwndMouseInputProvider.FilterMessage(System.IntPtr hwnd, MS.Internal.Interop.WindowMessage msg, System.IntPtr wParam, System.IntPtr lParam, ref bool handled)	Unknown
 	PresentationCore.dll!System.Windows.Interop.HwndSource.InputFilterMessage(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam, ref bool handled)	Unknown
 	WindowsBase.dll!MS.Win32.HwndWrapper.WndProc(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam, ref bool handled)	Unknown
 	WindowsBase.dll!MS.Win32.HwndSubclass.DispatcherCallbackOperation(object o)	Unknown
 	WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate callback, object args, int numArgs)	Unknown
 	WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.TryCatchWhen(object source, System.Delegate callback, object args, int numArgs, System.Delegate catchHandler)	Unknown
 	WindowsBase.dll!System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority priority, System.TimeSpan timeout, System.Delegate method, object args, int numArgs)	Unknown
 	WindowsBase.dll!MS.Win32.HwndSubclass.SubclassWndProc(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam)	Unknown

[murphymcquet-msft]

Gotcha, thanks for the detailed info! I was able to repro it locally, so I'll take a deeper look.