Update to windows-2025, upgrade to .NET 4.7.1 #1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried upgrading in steps and found that the failing test starts failing in .NET Framework 4.7.2 - it still passes in 4.7.1. I'll try that next and see if the image has it. |
window-2019 agent has been deprecated and is no longer available. The newer agents don't include support for .NET Framework 4.6.1 or the Windows SDK that the native projects targeted. I tried some workarounds to install support for them as part of the action YML, but failed. Newer versions of .NET Framework are available on the agent images, but 4.7.2 and later start failing one of the functional tests. So I've updated the projects to target .NET Framework 4.7.1 and the latest Windows SDK.
tyrielv
force-pushed
the
upgrade-workflow-image
branch
from
8e87e12 to
240f73e
Compare
tyrielv
changed the title
|
Thank you for your efforts @tyrielv! For my own understanding, is the problem with v4.8 this one? And the failure with v4.7.1 this one (no link because the log is too long)? |
|
Yes.
…On Thu, Jul 24, 2025, 12:38 AM Johannes Schindelin ***@***.***> wrote:
*dscho* left a comment (microsoft/VFSForGit#1852)
<#1852 (comment)>
Thank you for your efforts @tyrielv <https://github.com/tyrielv>!
For my own understanding, is the problem with v4.8 this one
<https://github.com/microsoft/VFSForGit/actions/runs/16479972994/job/46597820954#step:8:3804>
?
2025-07-23T21:11:34.6554350Z => GVFS.FunctionalTests.Tests.EnlistmentPerFixture.WorkingDirectoryTests(GVFS.FunctionalTests.FileSystemRunners.SystemIORunner).TruncatedObjectRedownloaded()
2025-07-23T21:11:34.6556747Z Test GVFS.FunctionalTests.Tests.EnlistmentPerFixture.WorkingDirectoryTests(GVFS.FunctionalTests.FileSystemRunners.SystemIORunner).TruncatedObjectRedownloaded()
2025-07-23T21:11:34.6558738Z Failed at 9:11:34 PM taking 00:00:01.7248655
2025-07-23T21:11:34.6560268Z The contents of C:\Repos\GVFSFunctionalTests\enlistment\faf8f8548a1c43fd928e\src\Test_EPF_WorkingDirectoryTests\TruncatedObjectRedownloaded.txt do not match what was expected
2025-07-23T21:11:34.6561695Z String lengths are both 45. Strings differ at index 34.
2025-07-23T21:11:34.6562899Z Expected: "Test contents for TruncatedObjectRedownloaded"
2025-07-23T21:11:34.6565874Z But was: "Test contents for TruncatedObjectR\f���\0\0�A\f��"
2025-07-23T21:11:34.6566548Z ---------------------------------------------^
And the failure with v4.7.1 this one (no link because the log is too long)?
2025-07-24T00:45:39.6890966Z => GVFS.FunctionalTests.Tests.LongRunningEnlistment.BasicFileSystemTests.ExpandedFileAttributesAreUpdated()
2025-07-24T00:45:39.6892942Z Test GVFS.FunctionalTests.Tests.LongRunningEnlistment.BasicFileSystemTests.ExpandedFileAttributesAreUpdated()
2025-07-24T00:45:39.6894065Z Failed at 12:45:39 AM taking 00:00:00.1391025
2025-07-24T00:45:39.6894532Z Last access time does not match
2025-07-24T00:45:39.6894917Z Expected: 2025-07-25 00:45:39.5492382
2025-07-24T00:45:39.6895345Z But was: 2025-07-24 00:45:38.5695344
—
Reply to this email directly, view it on GitHub
<#1852 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRLEVYNJKF4AECKGXZCTTD3KCEPDAVCNFSM6AAAAACCGZCBPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMJSGM4DAOJTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
mjcheetham
approved these changes
Jul 28, 2025
| @@ -14,19 +14,19 @@ | |||
| <ProjectGuid>{798DE293-6EDA-4DC4-9395-BE7A71C563E3}</ProjectGuid> | |||
| <Keyword>Win32Proj</Keyword> | |||
| <RootNamespace>GitHooksLoader</RootNamespace> | |||
| <WindowsTargetPlatformVersion>10.0.16299.0</WindowsTargetPlatformVersion> | |||
| <WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion> | |||
There was a problem hiding this comment.
I assume specifying just 10.0 means latest (and not build 10240)?
| </PropertyGroup> | ||
| <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" /> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration"> | ||
| <ConfigurationType>Application</ConfigurationType> | ||
| <UseDebugLibraries>true</UseDebugLibraries> | ||
| <PlatformToolset>v142</PlatformToolset> | ||
| <PlatformToolset>v143</PlatformToolset> |
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>net461</TargetFramework> | |||
| <TargetFramework>net471</TargetFramework> | |||
There was a problem hiding this comment.
.NET Framework 4.7.1 is installable as far back as Windows Server 2008 R2 SP1, so this should be ok since 2008 R2 was out of extended support on Jan 14, 2020.
mjcheetham
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window-2019 agent has been deprecated and is no longer available.
The newer agents don't include support for .NET Framework 4.6.1 or the Windows SDK that the native projects targeted. I tried some workarounds to install support for them as part of the action YML, but failed.
Instead, I've updated the projects to target .NET Framework 4.8 and the latest Windows SDK.