This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Update jsx sample with current react version, modern types - #144
Merged
Conversation
|
Wesley Wigham (@weswigham), |
Mohamed Hegazy (mhegazy)
approved these changes
Aug 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sample came to my attention since our RWC test for it had an error introduced in 2.4/2.5, caused by old react definitions making the construct it was using not-typesafe. Rather than accepting the error, I thought it better to update the sample with a current version of react.
This PR removes TSD and uses Types (@types), updates the readme to reference the
npmcommands, and updates the project to usereact15 (and, by extension,react-dom).