Take runtime semantics of numerically named properties into account. #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should also handle #728 |
To be fair, I don't think humanity knew about negative numbers until like 200 B.C.E.
DanielRosenwasser
force-pushed
the
numbersAreHard
branch
from
65a8c6c to
5a49bb6
Compare
Conflicts: tests/baselines/reference/numericIndexerConstrainsPropertyDeclarations.errors.txt
Specifically, a numeric property is simply now any property whose name N is equal to ToString(ToNumber(N)).
DanielRosenwasser
changed the title
DanielRosenwasser
force-pushed
the
numbersAreHard
branch
from
6f445e0 to
f933b58
Compare
Conflicts: src/compiler/checker.ts tests/baselines/reference/numericIndexerConstrainsPropertyDeclarations.errors.txt tests/baselines/reference/numericIndexerConstrainsPropertyDeclarations2.errors.txt
DanielRosenwasser
added a commit
that referenced
this pull request
Oct 17, 2014
Take runtime semantics of numerically named properties into account.
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.