Skip to content

Conversation

@rbuckton
Copy link
Contributor

The JSX transformer is designed to transform JSX-specific syntax into compatible JavaScript when the --jsx react compiler option.

Related Pull Requests:

Review on Reviewable

@rbuckton rbuckton changed the title Transforms transformer jsx Adds the JSX transformer Feb 23, 2016
@RyanCavanaugh
Copy link
Member

Am I reading this correctly that there are zero baseline changes?

@rbuckton
Copy link
Contributor Author

@RyanCavanaugh With only these transformations, the emitter isn't far enough along to run the tests and capture baseline changes. Those will come after I submit the last PR containing the module transformer.

let start = 0;
let pos = 0;
while (start < len) {
while (pos < len) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this temp is needed for readability or efficiency.

@sandersn
Copy link
Member

sandersn commented Mar 2, 2016

👍

rbuckton added a commit that referenced this pull request Mar 18, 2016
@rbuckton rbuckton merged commit 829a9df into transforms-transformer-ts Mar 18, 2016
@rbuckton rbuckton deleted the transforms-transformer-jsx branch March 18, 2016 22:47
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants