Conformance Tests for Spec Change in PR#624 #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var numPromise: Promise<number>; | ||
| var newPromise = numPromise.then(testFunction); | ||
| ~~~~~~~~~~~~ | ||
| !!! Argument of type '{ (n: number): Promise<number>; (s: string): Promise<string>; }' is not assignable to parameter of type '(x: number) => Promise<string>'. |
There was a problem hiding this comment.
Would be best to break this test into multiple files with errors and non-errors so that the non-error cases can still get a type baseline (we should probably just always do type baselines even for tests with errors)
There was a problem hiding this comment.
I think we should do type baselines for files that do not have syntax errors ?
|
@DanielRosenwasser why has not this gone in? |
Conflicts: tests/baselines/reference/parameterInitializersForwardReferencing.errors.txt
DanielRosenwasser
added a commit
that referenced
this pull request
Nov 25, 2014
Conformance Tests for Spec Change in PR#624
|
@mhegazy Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds/moves around tests for #624