Fix issue #6478 (bug in the language services) #6507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkillian
force-pushed
the
fix-prop-bug
branch
from
4cd3570 to
047c62c
Compare
|
Yep, done! |
DanielRosenwasser
added a commit
that referenced
this pull request
Jan 16, 2016
Fix issue #6478 (bug in the language services)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the changes suggested in #6478 (check that
symbolis not undefined right away) and found a fairly minimal repro which I added as a fourslash test case.Edit: The paragraph below is out of date now :)
The last commit, which reverts
package.jsonto use the latest nightly instead of a fixed version, causes this build to break since the latest nightly still has bugs in it. Most likely that revert should be done tomorrow, after this PR is in and a new, working nightly is released. I'll remove the revert from here so that can be done later if requested