Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions bug_repro_63094.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
"use strict";
// @experimentalDecorators: true
var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
class Greeter {
greet1() {
return "Hello, " + this.greeting;
}
}
__decorate([
deco
], Greeter.prototype, "greet1", null);
10 changes: 10 additions & 0 deletions bug_repro_63094.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// @experimentalDecorators: true

class Greeter {
@deco
greet1() {
return "Hello, " + this.greeting;
}
}

declare function deco(...args: [any, any, any]): any;
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36344,7 +36344,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
case SyntaxKind.GetAccessor:
case SyntaxKind.SetAccessor:
// For decorators with only two parameters we supply only two arguments
return signature.parameters.length <= 2 ? 2 : 3;
return getParameterCount(signature) <= 2 ? 2 : 3;
case SyntaxKind.Parameter:
return 3;
default:
Expand Down
11 changes: 11 additions & 0 deletions tests/cases/compiler/decoratorArityCrash.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// @experimentalDecorators: true
// @target: es5

declare function deco(...args: [any, any, any]): any;

class Greeter {
@deco
greet1() {
return "Hello, " + this.greeting;
}
}