Skip to content

Fix some tests that should have stayed ES5 #63086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 1 commit into from
Feb 4, 2026
+1,136 −3
Merged

Fix some tests that should have stayed ES5 #63086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...eference/arrayLiteralSpreadES5iterable.js → ...iteralSpreadES5iterable(target=es2015).js
View file
Open in desktop
File renamed without changes.
0 ...nce/arrayLiteralSpreadES5iterable.symbols → ...lSpreadES5iterable(target=es2015).symbols
View file
Open in desktop
File renamed without changes.
0 ...rence/arrayLiteralSpreadES5iterable.types → ...ralSpreadES5iterable(target=es2015).types
View file
Open in desktop
File renamed without changes.
28 changes: 28 additions & 0 deletions tests/baselines/reference/arrayLiteralSpreadES5iterable(target=es5).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
error TS5107: Option 'target=ES5' is deprecated and will stop functioning in TypeScript 7.0. Specify compilerOption '"ignoreDeprecations": "6.0"' to silence this error.


!!! error TS5107: Option 'target=ES5' is deprecated and will stop functioning in TypeScript 7.0. Specify compilerOption '"ignoreDeprecations": "6.0"' to silence this error.
==== arrayLiteralSpreadES5iterable.ts (0 errors) ====
function f0() {
var a = [1, 2, 3];
var a1 = [...a];
var a2 = [1, ...a];
var a3 = [1, 2, ...a];
var a4 = [...a, 1];
var a5 = [...a, 1, 2];
var a6 = [1, 2, ...a, 1, 2];
var a7 = [1, ...a, 2, ...a];
var a8 = [...a, ...a, ...a];
}

function f1() {
var a = [1, 2, 3];
var b = ["hello", ...a, true];
var b: (string | number | boolean)[];
}

function f2() {
var a = [...[...[...[...[...[]]]]]];
var b = [...[...[...[...[...[5]]]]]];
}

74 changes: 74 additions & 0 deletions tests/baselines/reference/arrayLiteralSpreadES5iterable(target=es5).js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
//// [tests/cases/conformance/es6/spread/arrayLiteralSpreadES5iterable.ts] ////

//// [arrayLiteralSpreadES5iterable.ts]
function f0() {
var a = [1, 2, 3];
var a1 = [...a];
var a2 = [1, ...a];
var a3 = [1, 2, ...a];
var a4 = [...a, 1];
var a5 = [...a, 1, 2];
var a6 = [1, 2, ...a, 1, 2];
var a7 = [1, ...a, 2, ...a];
var a8 = [...a, ...a, ...a];
}

function f1() {
var a = [1, 2, 3];
var b = ["hello", ...a, true];
var b: (string | number | boolean)[];
}

function f2() {
var a = [...[...[...[...[...[]]]]]];
var b = [...[...[...[...[...[5]]]]]];
}


//// [arrayLiteralSpreadES5iterable.js]
"use strict";
var __read = (this && this.__read) || function (o, n) {
var m = typeof Symbol === "function" && o[Symbol.iterator];
if (!m) return o;
var i = m.call(o), r, ar = [], e;
try {
while ((n === void 0 || n-- > 0) && !(r = i.next()).done) ar.push(r.value);
}
catch (error) { e = { error: error }; }
finally {
try {
if (r && !r.done && (m = i["return"])) m.call(i);
}
finally { if (e) throw e.error; }
}
return ar;
};
var __spreadArray = (this && this.__spreadArray) || function (to, from, pack) {
if (pack || arguments.length === 2) for (var i = 0, l = from.length, ar; i < l; i++) {
if (ar || !(i in from)) {
if (!ar) ar = Array.prototype.slice.call(from, 0, i);
ar[i] = from[i];
}
}
return to.concat(ar || Array.prototype.slice.call(from));
};
function f0() {
var a = [1, 2, 3];
var a1 = __spreadArray([], __read(a), false);
var a2 = __spreadArray([1], __read(a), false);
var a3 = __spreadArray([1, 2], __read(a), false);
var a4 = __spreadArray(__spreadArray([], __read(a), false), [1], false);
var a5 = __spreadArray(__spreadArray([], __read(a), false), [1, 2], false);
var a6 = __spreadArray(__spreadArray([1, 2], __read(a), false), [1, 2], false);
var a7 = __spreadArray(__spreadArray(__spreadArray([1], __read(a), false), [2], false), __read(a), false);
var a8 = __spreadArray(__spreadArray(__spreadArray([], __read(a), false), __read(a), false), __read(a), false);
}
function f1() {
var a = [1, 2, 3];
var b = __spreadArray(__spreadArray(["hello"], __read(a), false), [true], false);
var b;
}
function f2() {
var a = [];
var b = [5];
}
69 changes: 69 additions & 0 deletions tests/baselines/reference/arrayLiteralSpreadES5iterable(target=es5).symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
//// [tests/cases/conformance/es6/spread/arrayLiteralSpreadES5iterable.ts] ////

=== arrayLiteralSpreadES5iterable.ts ===
function f0() {
>f0 : Symbol(f0, Decl(arrayLiteralSpreadES5iterable.ts, 0, 0))

var a = [1, 2, 3];
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))

var a1 = [...a];
>a1 : Symbol(a1, Decl(arrayLiteralSpreadES5iterable.ts, 2, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))

var a2 = [1, ...a];
>a2 : Symbol(a2, Decl(arrayLiteralSpreadES5iterable.ts, 3, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))

var a3 = [1, 2, ...a];
>a3 : Symbol(a3, Decl(arrayLiteralSpreadES5iterable.ts, 4, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))

var a4 = [...a, 1];
>a4 : Symbol(a4, Decl(arrayLiteralSpreadES5iterable.ts, 5, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))

var a5 = [...a, 1, 2];
>a5 : Symbol(a5, Decl(arrayLiteralSpreadES5iterable.ts, 6, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))

var a6 = [1, 2, ...a, 1, 2];
>a6 : Symbol(a6, Decl(arrayLiteralSpreadES5iterable.ts, 7, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))

var a7 = [1, ...a, 2, ...a];
>a7 : Symbol(a7, Decl(arrayLiteralSpreadES5iterable.ts, 8, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))

var a8 = [...a, ...a, ...a];
>a8 : Symbol(a8, Decl(arrayLiteralSpreadES5iterable.ts, 9, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 1, 7))
}

function f1() {
>f1 : Symbol(f1, Decl(arrayLiteralSpreadES5iterable.ts, 10, 1))

var a = [1, 2, 3];
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 13, 7))

var b = ["hello", ...a, true];
>b : Symbol(b, Decl(arrayLiteralSpreadES5iterable.ts, 14, 7), Decl(arrayLiteralSpreadES5iterable.ts, 15, 7))
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 13, 7))

var b: (string | number | boolean)[];
>b : Symbol(b, Decl(arrayLiteralSpreadES5iterable.ts, 14, 7), Decl(arrayLiteralSpreadES5iterable.ts, 15, 7))
}

function f2() {
>f2 : Symbol(f2, Decl(arrayLiteralSpreadES5iterable.ts, 16, 1))

var a = [...[...[...[...[...[]]]]]];
>a : Symbol(a, Decl(arrayLiteralSpreadES5iterable.ts, 19, 7))

var b = [...[...[...[...[...[5]]]]]];
>b : Symbol(b, Decl(arrayLiteralSpreadES5iterable.ts, 20, 7))
}

Loading