Fix fourslash tests

[andrewbranch]

Fixes incorrect completions preferences passing and trailing commas in package.jsons

[Copilot]

Pull Request Overview

This PR fixes issues in fourslash tests related to invalid JSON syntax and incorrect completions API usage. The changes ensure that package.json files in test fixtures are valid JSON (removing trailing commas) and that completion preferences are passed correctly to the verify.completions API.

• Removes trailing commas from package.json files to ensure valid JSON syntax
• Fixes incorrect preferences passing in verify.completions calls where preferences were mistakenly placed as a separate argument instead of within the options object
• Adds runtime validation to catch future instances of incorrect preferences passing

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/cases/fourslash/server/importSuggestionsCache_invalidPackageJson.ts	Removes trailing comma from jsconfig.json
tests/cases/fourslash/organizeImportsReactJsxDev.ts	Removes trailing comma from react package.json
tests/cases/fourslash/organizeImportsReactJsx.ts	Removes trailing comma from react package.json
tests/cases/fourslash/completionsWithDeprecatedTag9.ts	Fixes preferences passing and adds missing completion entries
tests/cases/fourslash/completionsThisProperties_globalType.ts	Fixes preferences passing syntax
tests/cases/fourslash/codeFixMissingTypeAnnotationOnExports48.ts	Removes trailing comma from react package.json
tests/cases/fourslash/codeFixMissingTypeAnnotationOnExports47.ts	Removes trailing comma from react package.json
tests/cases/compiler/jsxClassAttributeResolution.tsx	Removes trailing comma from @types/react package.json
tests/baselines/reference/jsxClassAttributeResolution.js	Updates baseline to match fixed package.json
tests/baselines/reference/jsxClassAttributeResolution.errors.txt	Updates baseline to match fixed package.json
src/harness/fourslashInterfaceImpl.ts	Adds validation to detect incorrect preferences passing pattern

[Copilot]

Using optionsArray.indexOf(options) within a loop has O(n²) complexity. Store the index from the for...of loop instead. Change for (const options of optionsArray) to for (let i = 0; i < optionsArray.length; i++) and use i > 0 in the condition.

Suggested change

	for (const options of optionsArray) {
	if (options.preferences && Object.keys(options).length === 1 && optionsArray.length > 1 && optionsArray.indexOf(options) > 0) {
	for (let i = 0; i < optionsArray.length; i++) {
	const options = optionsArray[i];
	if (options.preferences && Object.keys(options).length === 1 && optionsArray.length > 1 && i > 0) {

[andrewbranch]

Not a completely wild review comment but not a concern here

[jakebailey]

This is a jsconfig so probably okay, but NBD

[andrewbranch]

Oh yeah, I just modified readJson and went to town

[jakebailey]

Does that mean jsconfigs are not using JSONC? Fun

[andrewbranch]

@typescript-bot cherry-pick to tsgo-port

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
cherry-pick to tsgo-port	✅ Started	✅ Results

[typescript-bot]

Hey, @andrewbranch! I've created #62642 for you.

[andrewbranch]

Lol, one of them is named "importSuggestionsCache_invalidPackageJson" so I better revert that one too

[andrewbranch]

Oh, it’s the same one I changed the jsconfig on

[andrewbranch]

These timeouts are getting annoying...