Skip to content

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250617192341571 to main #61887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

csigs
Copy link
Member

@csigs csigs commented Jun 17, 2025

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250617192341571 to main with localized lcls

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 19:23
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jun 17, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 17, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the localized diagnostic messages to incorporate support for the "node20" module option. The changes are applied across multiple locale files (e.g., trk, rus, ptb, kor, jpn, esn, deu, csy), ensuring that all user-facing messages correctly list "node20" among the supported module settings.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl Added 'node20' to the list of supported module options in the dynamic imports messages.
src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated diagnostic messages to include 'node20' consistently in Russian translations.
src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl Revised Portuguese localization to list 'node20' as a supported module option.
src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl Modified the Korean messages to add 'node20' among supported options.
src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated Japanese diagnostic strings to include 'node20'.
src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl Ensured Spanish messages now include the "node20" option.
src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated German messages to incorporate 'node20' support.
src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl Adjusted Czech diagnostic messages to reflect the addition of 'node20'.
Comments suppressed due to low confidence (8)

src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl:6019

  • The diagnostic message now includes 'node20' in the list of supported module options. Please verify that this update aligns with the latest language specifications and is applied consistently across all locales.
          <Val><![CDATA[Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', 'node18', 'node20', or 'nodenext'.]]></Val>

src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl:6025

  • Ensure that the updated Russian diagnostic message correctly reflects the new 'node20' support and maintains consistent formatting with other locales.
          <Val><![CDATA[Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', 'node18', 'node20', or 'nodenext'.]]></Val>

src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl:6019

  • The update adding 'node20' should be consistently applied; confirm that the Portuguese localization matches the updated diagnostic conventions.
          <Val><![CDATA[Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', 'node18', 'node20', or 'nodenext'.]]></Val>

src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl:6026

  • Verify that the Korean translation accurately incorporates 'node20' and that punctuation and formatting remain consistent with other locales.
          <Val><![CDATA[Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', 'node18', 'node20', or 'nodenext'.]]></Val>

src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl:6026

  • Ensure that the Japanese diagnostic message correctly reflects the addition of 'node20' and remains consistent with overall formatting standards.
          <Val><![CDATA[Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', 'node18', 'node20', or 'nodenext'.]]></Val>

src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl:6038

  • Confirm that the Spanish diagnostic message now includes 'node20' in the supported module options and that the update is consistent with other translations.
          <Val><![CDATA[Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', 'node18', 'node20', or 'nodenext'.]]></Val>

src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl:6023

  • Please check that the German diagnostic message update consistently adds 'node20' and that quotation marks are correctly used.
          <Val><![CDATA[Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', 'node18', 'node20', or 'nodenext'.]]></Val>

src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl:6035

  • Ensure that the Czech diagnostic message includes the updated 'node20' option and that the translation is consistent with changes in the other locales.
          <Val><![CDATA[Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', 'node18', 'node20', or 'nodenext'.]]></Val>

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jun 17, 2025
@jakebailey jakebailey merged commit f1d2494 into main Jun 17, 2025
30 checks passed
@jakebailey jakebailey deleted the lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250617192341571 branch June 17, 2025 20:28
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants